-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linuxPackages.nvidiaPackages.beta: 550.40.07 -> 555.42.02 #313440
Conversation
Result of 126 packages built:
|
Now that "The GSP firmware is now used by default on all GPUs which support it" the nvidia nixos module should always load the firmware (not for the open drivers only) https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/hardware/video/nvidia.nix#L537 |
Good catch, will make a change to the module. |
(Before this gets merged, I would be interested in trying it out. Is there any chance you could tell me what to set as the value for |
Result of 2 packages blacklisted:
105 packages built:
|
|
Been testing this for a bit now and I haven't seen any of the cursed XWayland flicking anymore with Plasma 6. It has always been showing up a bit sporadic, so it could also be coincidental -- not sure if the corresponding XWayland patch is even merged yet (in nixpkgs), but I remain hopeful.
Note that you'll probably end up compiling a looot of stuff locally if you directly use this branch, since it is based on a rather recent commit. I'd recommend cloning |
I've also been trying it on a GM204 (NVIDIA GTX 980), kernel 6.8.10. No issues so far:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use nixfmt-rfc-style
instead of nixpkgs-fmt
now, otherwise LGTM.
(ended up using a suggestion from https://www.reddit.com/r/NixOS/comments/1cx9wsy/question_nvidia_555_beta_released_today/?share_id=lGvzMmqyul-ZSdV8mhKLD&utm_content=1&utm_medium=android_app&utm_name=androidcss&utm_source=share&utm_term=2&onetap_auto=true&one_tap=true and it works like charm - looking forward to this landing here!) |
Worth mentioning explicit sync makes Firefox (and derivatives like Librewolf) crash on startup, in the meantime one would either not use this beta driver, or temporarily run Firefox through Xwayland by setting |
Result of 2 packages blacklisted:
105 packages built:
|
I usually base these commits on
Applied |
Not sure if this is the right place to report it, but my Hyprland seems to be crashing with this PR, whereas it works for Arch users with the new driver. Here are the logs (on v0.39.1, I also tried v0.40.0, and the xwayland-rewrite branch, but no luck): https://0x0.st/XZsN.log |
Can you confirm it is working without this PR, because it looks similar to https://www.reddit.com/r/hyprland/comments/1cva5g8/latest_version_crashing_on_nvidia/ which isn't using the new driver. |
Yes, I am currently writing this message from latest. |
Merging despite various issues since this is beta driver anyway. |
For people running into this issue: it only happens on the mainline kernel, it doesn't with xanmod, and reportedly zen. |
@wegank should we perhaps immediately backport this to 24.05?, given the official release is in 1 week it should still be fine |
I'm going to assume that this is a breaking change, which cannot be backported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting individually files shouldn't be done. Please wait in the future for the coordinated effort, otherwise we create lots of chores for everyone and don't properly ignore the commits in the revs file.
hardware.firmware = | ||
let | ||
isOpen = cfg.open; | ||
isNewUnfree = lib.versionAtLeast nvidia_x11.version "555"; | ||
in | ||
lib.optional (isOpen || isNewUnfree) nvidia_x11.firmware; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using let in here, makes the code a little more complex than it needs to be. Also isOpen is not really any improvement over cfg.open
Wow, this is still an issue with the current Firefox version 🥲 |
This will be fixed for the 130 version of firefox |
I'm aware of this, but considering 128 was only released 10 days ago and that there is always one release per month, we will have 130 in two months... |
Yes i known 😢 |
Forgive me for asking, but will this also be coming to 24.05 or will this only be in unstable until the next NixOS release? I can't find a lot of useful information about the process by which package updates filter down to stable, and so far from observation it seems arbitrary what packages come down to stable NixOS releases once they're out. |
These are the "offical" criteria for backports: So this won't be backported. To use this version regardless you can just install it from the nixos-unstable flake input or channel. |
If you want this on NixOS 24.05, you can add the following to your configuration: hardware.nvidia.package = config.boot.kernelPackages.nvidiaPackages.mkDriver {
version = "555.58.02";
sha256_64bit = "sha256-xctt4TPRlOJ6r5S54h5W6PT6/3Zy2R4ASNFPu8TSHKM=";
sha256_aarch64 = lib.fakeSha256;
openSha256 = lib.fakeSha256;
settingsSha256 = "sha256-ZpuVZybW6CFN/gz9rx+UJvQ715FZnAOYfHn5jt5Z2C8=";
persistencedSha256 = lib.fakeSha256;
}; |
Yeah, I'm doing this now, but I kinda wish I could just keep things to what's maintained in nixpkgs eventually.
I was about to argue this is a release with new functionality (Wouldn't explicit sync count as "new functionality?"), but I'm guessing there's breaking changes and that's why it's blocked from stable? |
I don't know if there are breaking changes.
Because of generations and the ease of rollbacks it's also not very scary to be on unstable. |
Fundamentally the nvidia drivers are really hostile to runtime updates, since that involves updating the userspace parts while the kernel parts require a reboot (or module juggling) to update. Until we have a way to pin the nvidia userspace libraries it is unlikely updates will be backported to stable. |
Description of changes
NVreg_EnableGpuFirmware=0
.hdmi_deepcolor=0
.nvidia-smi -r
to reset the primary GPU when using the open kernel modules.Closes #313423
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.