Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doomretro: 5.3 -> 5.4 #308519

Merged
merged 1 commit into from
May 3, 2024
Merged

doomretro: 5.3 -> 5.4 #308519

merged 1 commit into from
May 3, 2024

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 2, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/bradharding/doomretro/releases.

meta.description for doomretro is: A classic, refined DOOM source port

meta.homepage for doomretro is: https://www.doomretro.com/

meta.changelog for doomretro is: https://github.com/bradharding/doomretro/releases/tag/v5.4

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 5.4 with grep in /nix/store/sbhqsp773n2aqf65m78q5mk41m8m2bzn-doomretro-5.4
  • found 5.4 in filename of file in /nix/store/sbhqsp773n2aqf65m78q5mk41m8m2bzn-doomretro-5.4

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

doomretro
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/sbhqsp773n2aqf65m78q5mk41m8m2bzn-doomretro-5.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A doomretro https://github.com/r-ryantm/nixpkgs/archive/1f17183869f4ab9fe8ba3a6b5c2291aec3b3c56f.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/1f17183869f4ab9fe8ba3a6b5c2291aec3b3c56f#doomretro

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/sbhqsp773n2aqf65m78q5mk41m8m2bzn-doomretro-5.4
ls -la /nix/store/sbhqsp773n2aqf65m78q5mk41m8m2bzn-doomretro-5.4/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • doomretro

Maintainer pings

cc @AndersonTorres for testing.

@AndersonTorres
Copy link
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@AndersonTorres merge not permitted (#305350):
pkgs/games/doom-ports/doomretro/default.nix is not in pkgs/by-name/

@AndersonTorres
Copy link
Member

Let me migrate this, then.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 3, 2024
@wegank
Copy link
Member

wegank commented May 3, 2024

The package is called with

  doomretro = callPackage ../games/doom-ports/doomretro {
    inherit (darwin.apple_sdk.frameworks) Cocoa;
  };

which I'm not sure how to migrate. Please open a new PR for that, then.

@wegank wegank merged commit 63f95d3 into NixOS:master May 3, 2024
30 checks passed
@r-ryantm r-ryantm deleted the auto-update/doomretro branch May 3, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants