nvidia-x11: revert "add an assert that useSettings implies more tha…
#283729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `libsOnly`" THe change caused nixGL instantiation failures: - nix-community/nixGL#157 - nix-community/nixGL#154 I missed the fact that there is no easy way to oberride `useSettings` as it's an internal argument as ollosed to `useLibs`. Instead of fixing it let's revert it back and try again later. This reverts commit 9c51fb0.
13 tasks
ofborg
bot
added
8.has: package (new)
Kiskae
approved these changes
Jan 25, 2024
delroth
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n
libsOnly"THe change caused nixGL instantiation failures:
error: assertion '(useSettings -> (! libsOnly))' failednix-community/nixGL#157I missed the fact that there is no easy way to oberride
useSettingsas it's an internal argument as ollosed touseLibs.Instead of fixing it let's revert it back and try again later.
This reverts commit 9c51fb0.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.