Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nickel: fix build on darwin #268829

Merged
merged 1 commit into from
Nov 21, 2023
Merged

nickel: fix build on darwin #268829

merged 1 commit into from
Nov 21, 2023

Conversation

szlend
Copy link
Member

@szlend szlend commented Nov 20, 2023

Description of changes

Fixes #268777

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 21, 2023
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 21, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 21, 2023
@AndersonTorres AndersonTorres merged commit 5f8f287 into NixOS:master Nov 21, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

@matthiasbeyer matthiasbeyer Awaiting requested review from matthiasbeyer

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@felschr felschr Awaiting requested review from felschr

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: nickel
4 participants
@szlend @wegank @delroth @AndersonTorres