Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages: 11 -> 16 on Darwin and Linux #241692

Merged
merged 2 commits into from
Oct 19, 2023
Merged

llvmPackages: 11 -> 16 on Darwin and Linux #241692

merged 2 commits into from
Oct 19, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

This bumps llvmPackages on Darwin and Linux to 16, making LLVM 16.0.6 the version used by the Darwin stdenv

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This was referenced Jul 5, 2023
Closed
Closed
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jul 5, 2023
@ofborg ofborg bot requested review from adevress, prusnak and SuperSandro2000 July 5, 2023 15:38
This was referenced Jul 6, 2023
Open
Merged
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-macos-monthly/12330/40

@SuperSandro2000
Copy link
Member

@ofborg eval

@reckenrode
Copy link
Contributor Author

reckenrode commented Jul 13, 2023 •
edited
Loading

I’m pretty sure it wasn’t doing that when I opened this PR, but I’ll dig into the ofborg eval failure. Fortunately, I can reproduce it locally using outpaths.nix. Edit: It’s pkgsStatic issues again.

This was referenced Aug 2, 2023
Merged
Merged
@reckenrode
Copy link
Contributor Author

#247066 fixes the evaluation error causing the infinite recursion. I ran outPaths.nix locally with that PR cherry-picked, and it evaluates correctly now.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-macos-monthly/12330/41

@reckenrode
Copy link
Contributor Author

@ofborg eval

@ofborg ofborg bot requested a review from AndersonTorres August 22, 2023 21:21
@pwaller
Copy link
Contributor

pwaller commented Aug 24, 2023

Does this need a rebase after #246577 landed a couple of day ago?

@reckenrode
Copy link
Contributor Author

Does this need a rebase after #246577 landed a couple of day ago?

It shouldn’t. This PR doesn’t touch any of the files that were modified in that PR, and staging should have the changes from #246577 already merged into it anyway.

@reckenrode reckenrode mentioned this pull request Aug 25, 2023
Closed
12 tasks
@sielicki sielicki mentioned this pull request Aug 26, 2023
Closed
@reckenrode reckenrode mentioned this pull request Aug 26, 2023
Merged
@szlend
Copy link
Member

szlend commented Nov 20, 2023 •
edited
Loading

Nickel (a Rust project with some c++ deps) is failing to link some really basic symbols like "operator new(unsigned long)" after the upgrade to LLVM 16 on Darwin (#268777). Any advice on what to look for? I'm looking at the NIX_DEBUG=1 output and it does appear to be linking with libcxx/libcxxabi so I'm not sure what else to check for.

Edit: Solved. If anyone runs into this, here's the tracking issue and workaround: #166205

vbgl added a commit to vbgl/nixpkgs that referenced this pull request Nov 22, 2023
@vbgl
ocamlPackages.bap: use LLVM 14
2a39e05 
This fixes build after NixOS#241692
@vbgl vbgl mentioned this pull request Nov 22, 2023
Merged
13 tasks
vbgl added a commit that referenced this pull request Nov 29, 2023
@vbgl
ocamlPackages.bap: use LLVM 14
c4ffc83 
This fixes build after #241692
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
@vbgl @github-actions
ocamlPackages.bap: use LLVM 14
232e194 
This fixes build after #241692

(cherry picked from commit 2a39e05)
vbgl added a commit that referenced this pull request Nov 29, 2023
@vbgl
ocamlPackages.bap: use LLVM 14
f086297 
This fixes build after #241692

(cherry picked from commit 2a39e05)
@ipetkov ipetkov mentioned this pull request Dec 11, 2023
Merged
13 tasks
ipetkov added a commit to ipetkov/nixpkgs that referenced this pull request Dec 11, 2023
@ipetkov
dump_syms: fix building with LLVM 16
904913e 
Builds were broken on Darwin with
NixOS#241692, so this applies the
workaround from NixOS#166205
This was referenced Dec 17, 2023
Closed
Closed
Closed
Closed
@anmonteiro anmonteiro mentioned this pull request Dec 25, 2023
Merged
@wegank wegank mentioned this pull request Feb 15, 2024
Closed
13 tasks
mweinelt pushed a commit that referenced this pull request May 14, 2024
@ipetkov @mweinelt
dump_syms: fix building with LLVM 16
883185f 
Builds were broken on Darwin with
#241692, so this applies the
workaround from #166205

(cherry picked from commit 904913e)
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toonn toonn toonn approved these changes

@phaer phaer phaer approved these changes

@adevress adevress Awaiting requested review from adevress

@prusnak prusnak Awaiting requested review from prusnak

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@WilliButz WilliButz Awaiting requested review from WilliButz

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@gbtb gbtb Awaiting requested review from gbtb

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.