Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighthouse: init module #199855

Merged
merged 1 commit into from
Nov 7, 2022
Merged

lighthouse: init module #199855

merged 1 commit into from
Nov 7, 2022

Conversation

happysalada
Copy link
Contributor

Description of changes

mostly inspired from https://github.com/NixOS/nixpkgs/pull/128984/files
with a couple of tweaks.
@centromere @bachp you might be interested.

currently testing still.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 6, 2022
@happysalada happysalada force-pushed the lighthouse_module_init branch 3 times, most recently from 9cefaca to eb0b29b Compare November 6, 2022 14:18
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 6, 2022
@happysalada happysalada force-pushed the lighthouse_module_init branch 4 times, most recently from a288057 to da72f28 Compare November 6, 2022 14:55
@bachp bachp mentioned this pull request Nov 6, 2022
Closed
11 tasks
@happysalada happysalada force-pushed the lighthouse_module_init branch 8 times, most recently from 4cdbf09 to 4911a2c Compare November 6, 2022 17:15
@happysalada happysalada force-pushed the lighthouse_module_init branch 7 times, most recently from aa01425 to ed77af7 Compare November 7, 2022 12:10
@happysalada happysalada force-pushed the lighthouse_module_init branch 4 times, most recently from f3b1a9c to 075f481 Compare November 7, 2022 12:34
@happysalada
Copy link
Contributor Author

I'm going to merge this as I think it's usable and a better module will come from more feedback.
I would be happy to address any feedback in subsequent MRs.

@happysalada happysalada merged commit f4ff9c2 into NixOS:master Nov 7, 2022
@happysalada happysalada deleted the lighthouse_module_init branch November 7, 2022 12:58
@emmanuelrosa
Copy link
Contributor

I don't use this module, yet as of f4ff9c2 ...

nixos-rebuild build --flake .
building the system configuration...
error: The option `services.lighthouse.beacon' is used but not defined.
(use '--show-trace' to show detailed location information)

@bobby285271
Copy link
Member

bobby285271 commented Nov 7, 2022 •
edited
Loading

Yeah I also ran into similar issue when running a cinnamon test on ofborg several minutes ago:

error: The option `nodes.machine.services.lighthouse.beacon' is used but not defined.

https://github.com/NixOS/nixpkgs/runs/9335707690
https://logs.nix.ci/?attempt_id=84b5a0bb-6b0e-423a-ac40-1050cdae6146&key=nixos%2Fnixpkgs.200018

@happysalada
Copy link
Contributor Author

sorry about that #200025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp requested changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@happysalada @emmanuelrosa @bobby285271 @bachp