Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.normalizePath: the empty string is not a valid regex on darwin #197374

Merged
merged 1 commit into from
Oct 24, 2022
Merged

lib.normalizePath: the empty string is not a valid regex on darwin #197374

merged 1 commit into from
Oct 24, 2022

Conversation

symphorien
Copy link
Member

presumably due to using libc++'s regex lib instead of libstdc++ on linux

Fixes #177273 (comment)

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@symphorien
lib.normalizePath: the empty string is not a valid regex on darwin
3648b33 
presumably due to using libc++'s regex lib instead of libstdc++ on linux

Fixes NixOS#177273 (comment)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 23, 2022
@symphorien symphorien mentioned this pull request Oct 23, 2022
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 23, 2022
@symphorien symphorien mentioned this pull request Oct 23, 2022
Open
@zowoq
Copy link
Contributor

zowoq commented Oct 24, 2022

Seems to fix it, thank you.

@zowoq zowoq merged commit 956e35d into NixOS:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symphorien @zowoq