Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element-{web,desktop}: 1.11.3 -> 1.11.4 #189150

Merged
merged 1 commit into from
Aug 31, 2022
Merged

element-{web,desktop}: 1.11.3 -> 1.11.4 #189150

merged 1 commit into from
Aug 31, 2022

Conversation

fogti
Copy link
Contributor

@fogti fogti commented Aug 31, 2022 •
edited
Loading

Description of changes

See also: https://matrix.org/blog/2022/08/31/security-releases-matrix-js-sdk-19-4-0-and-matrix-react-sdk-3-53-0

Fixes #189143

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fogti fogti requested a review from yu-re-ka August 31, 2022 18:16
@fogti
Copy link
Contributor Author

fogti commented Aug 31, 2022

$ nixpkgs-review pr 189150

3 packages updated:

  • element-desktop
  • element-desktop (1.11.3 → 1.11.4)
  • element-web (1.11.3 → 1.11.4)

3 packages built:

  • element-desktop
  • element-desktop-wayland
  • element-web

@superherointj
Copy link
Contributor

Result of nixpkgs-review pr 189150 run on x86_64-linux 1

3 packages built:
  • element-desktop
  • element-desktop-wayland
  • element-web

superherointj
superherointj approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@superherointj superherointj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@superherointj superherointj merged commit 3db1dce into NixOS:master Aug 31, 2022
@github-actions
Copy link
Contributor

Backport failed for release-22.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.05
git worktree add -d .worktree/backport-189150-to-release-22.05 origin/release-22.05
cd .worktree/backport-189150-to-release-22.05
git checkout -b backport-189150-to-release-22.05
ancref=$(git merge-base 1e0e95e88ed48e05dc9c0e898e84c87cc4c50368 8c68069328de82e719f3c8f94e7745570664e3e1)
git cherry-pick -x $ancref..8c68069328de82e719f3c8f94e7745570664e3e1

@fogti fogti deleted the element-bump branch August 31, 2022 20:27
@Ma27
Copy link
Member

Ma27 commented Aug 31, 2022

Unless someone beats me I'll file a backport PR tomorrow :)

@Ma27 Ma27 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 31, 2022
@github-actions
Copy link
Contributor

Backport failed for release-22.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.05
git worktree add -d .worktree/backport-189150-to-release-22.05 origin/release-22.05
cd .worktree/backport-189150-to-release-22.05
git checkout -b backport-189150-to-release-22.05
ancref=$(git merge-base 1e0e95e88ed48e05dc9c0e898e84c87cc4c50368 8c68069328de82e719f3c8f94e7745570664e3e1)
git cherry-pick -x $ancref..8c68069328de82e719f3c8f94e7745570664e3e1

Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Sep 1, 2022
@Ma27
element-{web,desktop}: 1.11.0 -> 1.11.4, fix CVE-2022-36059 & CVE-202…
5e01e0a 
…2-36060

Backport of NixOS#189150, NixOS#186133.
@Ma27 Ma27 mentioned this pull request Sep 1, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superherointj superherointj superherointj approved these changes

@yu-re-ka yu-re-ka Awaiting requested review from yu-re-ka

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

element-{desktop,web}: CVE-2022-36059,60, patch release 1.11.4
3 participants
@fogti @superherointj @Ma27