-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go,goBuildModules: bump default go version to 1.18 #179622
Conversation
broken on target branch:
all failed packages in the upcomming nixpkgs-review post I double checked if they where really broken, pinned them to go 1.17 or for unrelated or already broken packages ignored them. I also ignored everything cuda related because the source download (>2GB) is always failing for me. |
ipget: #179670 Will get to the others at some other point |
(moved my comments inline, duh) |
Result of 27 packages marked as broken and skipped:
86 packages failed to build:
1557 packages built:
|
This looks fine to me, I'll let someone else give the final approval. I do think we can either fix or drop all the remaining packages, that can be left as future work over the next couple of weeks before 1.19 comes out |
d8e04c5
to
0a80c84
Compare
@ofborg eval |
Have you checked all What are you planning to do about all darwin breakage on x86_64? Leaving contributors to figure out how to deal with dozens of broken and unfixable packages doesn't seem like a good idea. I'd suggest doing a hydra run just for |
I checked some and then determined that they won't change after none of my test examples changed. Edit: Currently double checking with the current rebuilds. If we don't get a hash mismatch then this will be safe. wget https://gist.githubusercontent.com/GrahamcOfBorg/41d3704882eceb3aa9de0c53f89bb298/raw/3c7143944161f0653dced2159bb4cd913a23d043/Changed%2520Paths
rg x86_64-linux Changed%20Paths | awk '{print $2}' | rg -v -e ^python310Packages -e ^python39Packages -e ^linuxKernel -e ^linuxPackages | xargs -I{} nix build --rebuild .#{}.go-modules
I pinged them in the darwin channel 5 days ago, 3 days ago and just now. So far I didn't receive any feedback. The Go 1.18 update is already stalled for a good amount of time and I don't want to make it another project held back by proprietary darwin. Lets wait a few days if someone provides feedback, otherwise I would just move ahead. |
Here goes nothin! |
the nix-rebuild comment doesn't look right to me, the --rebuild flag seems to only be part of |
really? ufff... |
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes