Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go,goBuildModules: bump default go version to 1.18 #179622

Merged
merged 61 commits into from
Jul 15, 2022

Conversation

SuperSandro2000
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jun 29, 2022

broken on target branch:

  • cod
  • python310Packages.ipfshttpclient
  • duplicacy (does not use go.mod and buildGoPackage has outdated hashes, not going to fix)
  • envoy

all failed packages in the upcomming nixpkgs-review post I double checked if they where really broken, pinned them to go 1.17 or for unrelated or already broken packages ignored them. I also ignored everything cuda related because the source download (>2GB) is always failing for me.

@ofborg ofborg bot requested a review from bzizou June 29, 2022 23:26
@rski rski self-requested a review June 30, 2022 05:01
@rski
Copy link
Contributor

rski commented Jun 30, 2022

ipget: #179670

Will get to the others at some other point

@rski
Copy link
Contributor

rski commented Jun 30, 2022

(moved my comments inline, duh)

@SuperSandro2000
Copy link
Member Author

#179709

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 179622 run on x86_64-linux 1

27 packages marked as broken and skipped:
  • codimd
  • coyim
  • deltachat-electron
  • gnatsd
  • intensity-normalization
  • kakounePlugins.kak-fzf
  • libsForQt512.bismuth
  • libsForQt514.bismuth
  • meme
  • oauth2_proxy
  • packet-cli
  • prometheus-openvpn-exporter
  • python310Packages.asyncio-nats-client
  • python310Packages.caffe
  • python310Packages.caffeWithCuda
  • python310Packages.intensity-normalization
  • python310Packages.optuna
  • python310Packages.rl-coach
  • python310Packages.tensorflow-build_2
  • python39Packages.asyncio-nats-client
  • python39Packages.intensity-normalization
  • python39Packages.optuna
  • python39Packages.rl-coach
  • python39Packages.tensorflow-build_2
  • syncthing-cli
  • timescale-prometheus
  • utahfs
86 packages failed to build:
  • addlicense
  • charliecloud
  • cod
  • code-server
  • cosign
  • dendrite
  • docker
  • docker-gc
  • duplicacy
  • fn-cli
  • garble
  • go-chromecast
  • go-langserver
  • go-mockery
  • gomplate
  • gophernotes
  • gosca
  • gotktrix
  • gowitness
  • grafana-agent
  • gsctl
  • hyprspace
  • ipget
  • kconf
  • kube-linter
  • kubectl
  • kubectl-convert
  • kubernetes
  • kuma
  • kuma-cp
  • kuma-prometheus-sd
  • kumactl
  • kustomize_3
  • kuttl
  • lefthook
  • livedl
  • marathonctl
  • mole
  • nvidia-docker
  • out-of-tree
  • pipework
  • pomerium
  • prometheus-nats-exporter
  • python310Packages.dask-yarn
  • python310Packages.dm-haiku
  • python310Packages.google-cloud-bigquery
  • python310Packages.ibis-framework
  • python310Packages.ipfshttpclient
  • python310Packages.jupyter-repo2docker
  • python310Packages.tensorflowWithCuda
  • python39Packages.baselines
  • python39Packages.caffeWithCuda
  • python39Packages.dalle-mini
  • python39Packages.datafusion
  • python39Packages.dm-haiku
  • python39Packages.edward
  • python39Packages.elegy
  • python39Packages.flax
  • python39Packages.google-cloud-bigquery
  • python39Packages.gpt-2-simple
  • python39Packages.ibis-framework
  • python39Packages.ipfshttpclient
  • python39Packages.jupyter-repo2docker
  • python39Packages.mask-rcnn
  • python39Packages.optax
  • python39Packages.pot
  • python39Packages.scikit-tda
  • python39Packages.tensorflow (python39Packages.tensorflowWithoutCuda)
  • python39Packages.tensorflow-datasets
  • python39Packages.tensorflow-probability
  • python39Packages.tensorflowWithCuda
  • python39Packages.tflearn
  • python39Packages.treex
  • python39Packages.umap-learn
  • python39Packages.vqgan-jax
  • shopify-themekit
  • simplehttp2server
  • singularity
  • sish
  • toxiproxy
  • udocker
  • unconvert
  • update-nix-fetchgit
  • vegeta
  • vikunja-api
  • wtf
1557 packages built:
  • _3mux
  • actionlint
  • adb-sync
  • adreaper
  • adrgen
  • aerc
  • age
  • agebox
  • air
  • alertmanager-bot
  • alertmanager-irc-relay
  • align
  • aliyun-cli
  • alpnpass
  • alps
  • amass
  • amazon-ecr-credential-helper
  • amfora
  • antibody
  • apko
  • appvm
  • aptly
  • archiver
  • arduino-ci
  • arduino-cli
  • argo
  • argo-rollouts
  • argocd
  • argocd-autopilot
  • arkade
  • arrow-cpp
  • arsenal
  • ascii-image-converter
  • asciigraph
  • asmfmt
  • assh
  • assign-lb-ip
  • atlantis
  • authz0
  • autospotting
  • aviator
  • aws-env
  • aws-iam-authenticator
  • aws-lambda-rie
  • aws-nuke
  • aws-rotate-key
  • aws-sso-cli
  • aws-vault
  • awsls
  • awsrm
  • awsweeper
  • azure-storage-azcopy
  • babelfish
  • badrobot
  • base16-universal-manager
  • bat-extras.prettybat
  • bazel-buildtools
  • bazel-gazelle
  • bazel-kazel
  • bazel-remote
  • bazelisk
  • bee
  • bee-clef
  • bee-unstable
  • berglas
  • bettercap
  • bingo
  • bird-lg
  • bit
  • bloat
  • blockbook
  • blocky
  • bluewalker
  • boltbrowser
  • bombadillo
  • boohu
  • boringssl
  • bosh-cli
  • bosun
  • bpfmon
  • brig
  • brillo
  • brook
  • browserpass
  • browsh
  • buildah
  • buildah-unwrapped
  • buildkit
  • buildkit-nix
  • buildkite-agent-metrics
  • buildkite-cli
  • buildpack
  • bump
  • bundix
  • bunnyfetch
  • butane
  • butler
  • cabal2nix
  • caddy
  • cadvisor
  • calyx-vpn
  • cameradar
  • captive-browser
  • cariddi
  • cassowary
  • cayley
  • cdk-go
  • certgraph
  • certigo
  • certmgr
  • certmgr-selfsigned
  • certstrap
  • cf-vault
  • cfssl
  • cgiserver
  • chamber
  • changetower
  • chaos
  • charm
  • chart-testing
  • cheat
  • checkip
  • checkmake
  • checkmate
  • chezmoi
  • chisel
  • chopchop
  • chroma
  • cidrgrep
  • cilium-cli
  • circleci-cli
  • civo
  • clair
  • claws
  • cli53
  • cliam
  • clickhouse-backup
  • cliphist
  • clipman
  • cloud-nuke
  • cloud-sql-proxy
  • cloudbrute
  • cloudflared
  • cloudfoundry-cli
  • cloudlist
  • cloudmonkey
  • clusterctl
  • cmctl
  • cni
  • cni-plugin-flannel
  • cni-plugins
  • cockroachdb
  • codeowners
  • codesearch
  • cointop
  • colima
  • compile-daemon
  • confd
  • confluencepot
  • conform
  • conftest
  • consul
  • consul-alerts
  • consul-template
  • containerd
  • containerpilot
  • convoy
  • cordless
  • coredns
  • crane
  • crate2nix
  • crd2pulumi
  • credential-detector
  • credhub-cli
  • cri-o
  • cri-tools
  • crlfuzz
  • croc
  • crun
  • crystal2nix
  • cshatag
  • csvdiff
  • ctop
  • cue
  • curlie
  • dagger
  • dalfox
  • damon
  • dapper
  • dapr-cli
  • dasel
  • dashing
  • datadog-agent
  • datadog-process-agent
  • datree
  • dave
  • dbmate
  • dcrd
  • dcrwallet
  • dcs
  • ddosify
  • deadcode
  • deepsea
  • deltachat-desktop
  • delve
  • demoit
  • dep
  • dep2nix
  • desync
  • devd
  • devspace
  • dex-oidc
  • dgoss
  • dgraph
  • direnv
  • diskrsync
  • dismap
  • distrobuilder
  • dive
  • dnscrypt-proxy2
  • dnsmon-go
  • dnsmonster
  • dnsname-cni
  • dnsproxy
  • dnstake
  • dnsx
  • do-agent
  • docker-buildx
  • docker-client
  • docker-compose
  • docker-credential-gcr
  • docker-credential-helpers
  • docker-distribution
  • docker-ls
  • docker-machine
  • docker-machine-kvm
  • docker-machine-kvm2
  • docker-proxy
  • docker-slim
  • dockfmt
  • dockle
  • docopts
  • doctl
  • docui
  • documize-community
  • dontgo403
  • doppler
  • dorkscout
  • driftctl
  • drive
  • drone
  • drone-cli
  • drone-oss
  • drone-runner-docker
  • drone-runner-exec
  • dstask
  • dstp
  • duckling-proxy
  • duf
  • dyff
  • earlybird
  • earthly
  • easyjson
  • ec2-metadata-mock
  • echoip
  • ecs-agent
  • editorconfig-checker
  • efm-langserver
  • ejson
  • ejson2env
  • eksctl
  • element
  • elfinfo
  • elvish
  • endlessh-go
  • ent-go
  • envconsul
  • envsubst
  • erigon
  • esbuild
  • esbuild_netlify
  • etcd
  • etcd_3_4
  • etcd_3_5
  • ets
  • evans
  • evmdis
  • exercism
  • exoscale-cli
  • expenses
  • extrude
  • f1viewer
  • f2
  • faas-cli
  • fac
  • faraday
  • fastly
  • ffuf
  • filebeat
  • filebeat7
  • filegive
  • filtron
  • fioctl
  • firectl
  • fishPlugins.forgit
  • fishPlugins.fzf-fish
  • fission
  • fits-cloudctl
  • flannel
  • flex-ncat
  • flex-ndax
  • flintlock
  • fluxcd
  • fluxctl
  • fly
  • flyctl
  • fontpreview
  • fq
  • frangipanni
  • frp
  • frugal
  • fscrypt-experimental
  • fsql
  • fulcio
  • fwanalyzer
  • fx
  • fzf
  • fzf-zsh
  • galene
  • galer
  • gatekeeper
  • gau
  • gauge
  • gb-backup
  • gcrane
  • gcsfuse
  • gdrive
  • gdu
  • geek-life
  • gemget
  • geoipupdate
  • gg-scm
  • gh
  • gh-eco
  • gh-ost
  • ghorg
  • ghostunnel
  • ghq
  • ghr
  • ginkgo
  • git-annex-remote-rclone
  • git-appraise
  • git-bug
  • git-chglog
  • git-codereview
  • git-credential-1password
  • git-hound
  • git-lfs
  • git-sizer
  • git-subtrac
  • git-team
  • git-town
  • gitaly
  • gitbatch
  • gitea
  • github-backup
  • github-commenter
  • github-release
  • gitjacker
  • gitlab-pages
  • gitlab-runner
  • gitlab-shell
  • gitlab-workhorse
  • gitleaks
  • gitls
  • gitty
  • gjo
  • glab
  • glide
  • gllvm
  • glock
  • glooctl
  • glow
  • gmailctl
  • gmnitohtml
  • go-2fa
  • go-audit
  • go-bindata
  • go-bindata-assetfs
  • go-camo
  • go-check
  • go-containerregistry
  • go-cve-search
  • go-dependency-manager
  • go-ethereum
  • go-jira
  • go-jsonnet
  • go-junit-report
  • go-libp2p-daemon
  • go-license-detector
  • go-md2man
  • go-migrate
  • go-minimock
  • go-motion
  • go-mtpfs
  • go-neb
  • go-org
  • go-outline
  • go-protobuf
  • go-rice
  • go-sct
  • go-shadowsocks2
  • go-swag
  • go-swagger
  • go-symbols
  • go-task
  • go-toml
  • go-tools
  • go-upower-notify
  • go2nix
  • go365
  • goa
  • goawk
  • gobetween
  • gobgp
  • gobgpd
  • gobuster
  • gocode
  • gocode-gomod
  • goconst
  • goconvey
  • gocryptfs
  • gocyclo
  • godef
  • godns
  • godspeed
  • godu
  • gof5
  • goflow
  • gofu
  • gofumpt
  • gogetdoc
  • gogs
  • gohai
  • goimapnotify
  • gojq
  • gojsontoyaml
  • gokart
  • golangci-lint-langserver
  • golint
  • gomacro
  • gomapenum
  • gomatrix
  • gomodifytags
  • gomuks
  • gonic
  • goofys
  • google-guest-agent
  • gopacked
  • gopkgs
  • gops
  • gore
  • goreman
  • goreplay
  • goresym
  • gortr
  • gosec
  • gosh
  • gospider
  • goss
  • gost
  • gosu
  • gotest
  • gotests
  • gotestsum
  • gotestwaf
  • gotify-cli
  • gotify-server
  • gotop
  • gotty
  • gotypist
  • govc
  • govendor
  • govers
  • gox
  • gpt2tc
  • grafana
  • grafana-loki
  • grafana_reporter
  • grit
  • grobi
  • gron
  • grpc-client-cli
  • grpc-gateway
  • grpcui
  • grpcurl
  • gst
  • guardian-agent
  • gucci
  • gvisor-containerd-shim
  • gvproxy
  • gx
  • gx-go
  • hakrawler
  • harmonist
  • hasmail
  • hasura-cli
  • hci
  • hcl2json
  • hcloud
  • hd-idle
  • heartbeat
  • heartbeat7
  • hecate
  • hedgedoc
  • helm-docs
  • helmfile
  • helmsman
  • hercules-ci-agent
  • hetzner-kube
  • hey
  • hilbish
  • hivemind
  • hjson-go
  • hockeypuck
  • holo-build
  • hologram
  • home-assistant-component-tests.environment_canada
  • honeytrap
  • hostctl
  • hostess
  • hound
  • hover
  • htmltest
  • httpdump
  • httplab
  • httpx
  • hub
  • hubble
  • humioctl
  • hut
  • hydron
  • hydroxide
  • hyperledger-fabric
  • iam-policy-json-to-terraform
  • iamy
  • ic-keysmith
  • iferr
  • ignite
  • ijq
  • img
  • img-cat
  • imgcrypt
  • imgproxy
  • impl
  • ineffassign
  • influxdb
  • influxdb2
  • influxdb2-cli
  • influxdb2-server
  • interactsh
  • interlock
  • invidious
  • ipfs
  • ipfs-cluster
  • ipfs-migrator
  • ipfs-migrator-all-fs-repo-migrations
  • ipfs-migrator-unwrapped
  • ipinfo
  • irccat
  • ircdog
  • istioctl
  • ivy
  • jaeles
  • janus-gateway
  • jd-diff-patch
  • jellycli
  • jid
  • jiq
  • jira-cli-go
  • jmespath
  • joker
  • journalbeat
  • jp
  • json2hcl
  • jsonnet-bundler
  • jsubfinder
  • juju
  • jump
  • jwt-hack
  • jx
  • k0sctl
  • k2tf
  • k3s
  • k3sup
  • k6
  • k9s
  • kaf
  • kail
  • kakounePlugins.fzf-kak
  • kapacitor
  • kapowbang
  • kapp
  • kappanhang
  • kbfs
  • kbst
  • kcli
  • kepubify
  • keybase
  • keycard-cli
  • keylight-controller-mschneider82
  • kfctl
  • kiln
  • kiterunner
  • kn
  • ko
  • kompose
  • konstraint
  • kontemplate
  • kopia
  • kops
  • kops_1_21
  • kops_1_22
  • kpt
  • kratos
  • krelay
  • krew
  • kt
  • kube-capacity
  • kube-prompt
  • kube-router
  • kube-score
  • kube3d
  • kubeaudit
  • kubebuilder
  • kubecfg
  • kubecolor
  • kubeconform
  • kubectl-doctor
  • kubectl-evict-pod
  • kubectl-example
  • kubectl-tree
  • kubectx
  • kubedb-cli
  • kubei
  • kubelogin
  • kubelogin-oidc
  • kubemq-community
  • kubemqctl
  • kubent
  • kubeone
  • kubeprompt
  • kubepug
  • kubergrunt
  • kubernetes-controller-tools
  • kubernetes-helm
  • kubernetes-helm-wrapped
  • kubescape
  • kubeseal
  • kubesec
  • kubespy
  • kubeval
  • kubevirt
  • kuma-dp
  • kuma-experimental
  • kustomize
  • kustomize-sops
  • lab
  • lazygit
  • leaps
  • lego
  • lemonade
  • levant
  • lf
  • libgen-cli
  • librarian-puppet-go
  • librespeed-cli
  • libsForQt5.bismuth
  • libtensorflow
  • lifecycled
  • lightning-loop
  • lightning-pool
  • lightwalletd
  • ligolo-ng
  • lima
  • limesctl
  • linkerd
  • linkerd_edge
  • linuxKernel.packages.linux_5_4.oci-seccomp-bpf-hook (linuxKernel.packages.linux_5_10.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_5_4_hardened.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_hardened.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_latest_libre.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_libre.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_lqx.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_testing_bcachefs.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_xanmod.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_xanmod_latest.oci-seccomp-bpf-hook ,linuxKernel.packages.linux_zen.oci-seccomp-bpf-hook)
  • linuxkit
  • litestream
  • livepeer
  • llama
  • lmp
  • lnch
  • lnd
  • lndconnect
  • lndhub-go
  • localtime
  • loccount
  • log4j-sniffer
  • log4j-vuln-scanner
  • lokalise2-cli
  • lxd
  • mackerel-agent
  • maddy
  • madonctl
  • mage
  • magnetico
  • mailhog
  • maker-panel
  • maligned
  • mani
  • mapcidr
  • mark
  • massren
  • matrix-corporal
  • matterbridge
  • matterircd
  • mattermost
  • mautrix-whatsapp
  • mbtileserver
  • mdr
  • melt
  • meme-image-generator
  • mesos-dns
  • metabigor
  • metal-cli
  • metricbeat
  • metricbeat7
  • micro
  • microplane
  • miller
  • mimir
  • minica
  • miniflux
  • minify
  • minikube
  • minio
  • minio-certgen
  • minio-client
  • minishift
  • mirrorbits
  • mkcert
  • mm
  • mmake
  • mmark
  • mmctl
  • mmv-go
  • mob
  • mockgen
  • mod
  • modd
  • molly-brown
  • mongodb-tools
  • monsoon
  • mop
  • morph
  • morty
  • mpd-mpris
  • mtail
  • mtr-exporter
  • mubeng
  • mullvad
  • multus-cni
  • mustache-go
  • mynewt-newt
  • naabu
  • napari (python310Packages.napari)
  • nar-serve
  • nats-server
  • nats-streaming-server
  • nats-top
  • natscli
  • navi
  • ncdns
  • nebula
  • neo-cowsay
  • nerdctl
  • netdata
  • netlify-cli
  • neuron-notes
  • nextdns
  • nfpm
  • nginx-sso
  • nix-build-uncached
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-scripts
  • nix-store-gcs-proxy
  • nix-update-source
  • nixops-dns
  • nkeys
  • nmap-formatter
  • node-problem-detector
  • noisetorch
  • nomad-autoscaler
  • nomad-driver-podman
  • nomad-pack
  • norouter
  • nosqli
  • notary
  • noti
  • notify
  • npins
  • nsq
  • ntfy-sh
  • nuclei
  • nvidia-podman
  • nwg-drawer
  • nwg-menu
  • nwg-panel
  • oak
  • oapi-codegen
  • oauth2-proxy
  • obfs4
  • ocm
  • odo
  • oh
  • oil-buku
  • okteto
  • oneshot
  • onionshare
  • onionshare-gui
  • ooniprobe-cli
  • open-policy-agent
  • openring
  • openshift
  • opensmtpd-filter-rspamd
  • opensnitch
  • opentelemetry-collector
  • opentelemetry-collector-contrib
  • openvscode-server
  • operator-sdk
  • oras
  • oshka
  • ossutil
  • osv-detector
  • otpauth
  • overmind
  • owncast
  • pachyderm
  • packer
  • packet
  • packet-sd
  • packetbeat7
  • packr
  • paco
  • pam_ussh
  • paperlike-go
  • parquet-tools
  • passage
  • passphrase2pgp
  • pathvector
  • pbgopy
  • pcstat
  • pdfcpu
  • peach
  • pebble
  • peco
  • perkeep
  • pet
  • pg_featureserv
  • pg_flame
  • pg_tileserv
  • pgcenter
  • pgo-client
  • pgweb
  • photon-rss
  • phrase-cli
  • pigeon
  • pistol
  • pixiecore
  • pkger
  • platinum-searcher
  • plik
  • plikd
  • pluto
  • podgrab
  • podman
  • podman-tui
  • podman-unwrapped
  • pomerium-cli
  • popeye
  • powerline-go
  • pprof
  • prefetch-yarn-deps
  • prism
  • prom2json
  • prometheus-alertmanager
  • prometheus-apcupsd-exporter
  • prometheus-artifactory-exporter
  • prometheus-aws-s3-exporter
  • prometheus-bind-exporter
  • prometheus-bird-exporter
  • prometheus-blackbox-exporter
  • prometheus-collectd-exporter
  • prometheus-consul-exporter
  • prometheus-dnsmasq-exporter
  • prometheus-domain-exporter
  • prometheus-dovecot-exporter
  • prometheus-fastly-exporter
  • prometheus-flow-exporter
  • prometheus-fritzbox-exporter
  • prometheus-gitlab-ci-pipelines-exporter
  • prometheus-haproxy-exporter
  • prometheus-influxdb-exporter
  • prometheus-jitsi-exporter
  • prometheus-json-exporter
  • prometheus-keylight-exporter
  • prometheus-lnd-exporter
  • prometheus-mail-exporter
  • prometheus-mikrotik-exporter
  • prometheus-minio-exporter
  • prometheus-modemmanager-exporter
  • prometheus-mysqld-exporter
  • prometheus-nextcloud-exporter
  • prometheus-nginx-exporter
  • prometheus-nginxlog-exporter
  • prometheus-node-exporter
  • prometheus-openldap-exporter
  • prometheus-pihole-exporter
  • prometheus-postfix-exporter
  • prometheus-postgres-exporter
  • prometheus-process-exporter
  • prometheus-pushgateway
  • prometheus-rabbitmq-exporter
  • prometheus-redis-exporter
  • prometheus-rtl_433-exporter
  • prometheus-script-exporter
  • prometheus-smartctl-exporter
  • prometheus-smokeping-prober
  • prometheus-snmp-exporter
  • prometheus-sql-exporter
  • prometheus-statsd-exporter
  • prometheus-surfboard-exporter
  • prometheus-systemd-exporter
  • prometheus-varnish-exporter
  • prometheus-xmpp-alerts
  • promscale
  • promtail
  • prosody-filer
  • proto-contrib
  • protoc-gen-doc
  • protoc-gen-entgrpc
  • protoc-gen-go
  • protoc-gen-go-grpc
  • protoc-gen-go-vtproto
  • protoc-gen-twirp
  • protoc-gen-twirp_php
  • protoc-gen-twirp_swagger
  • protoc-gen-twirp_typescript
  • protoc-gen-validate
  • protolint
  • protolock
  • protonmail-bridge
  • prototool
  • prow
  • proxify
  • pscale
  • pufferpanel
  • pulumictl
  • pup
  • pwdsafety
  • python310Packages.aplpy
  • python310Packages.asdf
  • python310Packages.astroquery
  • python310Packages.baselines
  • python310Packages.batchgenerators
  • python310Packages.boxx
  • python310Packages.bpycv
  • python310Packages.casa-formats-io
  • python310Packages.clifford
  • python310Packages.dask
  • python310Packages.dask-gateway
  • python310Packages.dask-glm
  • python310Packages.dask-image
  • python310Packages.dask-jobqueue
  • python310Packages.dask-ml
  • python310Packages.dask-mpi
  • python310Packages.datafusion
  • python310Packages.datasets
  • python310Packages.datashader
  • python310Packages.db-dtypes
  • python310Packages.devito
  • python310Packages.diagrams
  • python310Packages.distributed
  • python310Packages.dremel3dpy
  • python310Packages.edward
  • python310Packages.env-canada
  • python310Packages.glymur
  • python310Packages.gpt-2-simple
  • python310Packages.handout
  • python310Packages.image-match
  • python310Packages.imagecorruptions
  • python310Packages.imageio
  • python310Packages.imgaug
  • python310Packages.intake
  • python310Packages.intake-parquet
  • python310Packages.ipwhl
  • python310Packages.mask-rcnn
  • python310Packages.moviepy
  • python310Packages.napari-console
  • python310Packages.napari-svg
  • python310Packages.nats-py
  • python310Packages.pims
  • python310Packages.pot
  • python310Packages.pyarrow
  • python310Packages.pyfftw
  • python310Packages.pyfzf
  • python310Packages.pyregion
  • python310Packages.pytest-astropy
  • python310Packages.pytest-astropy-header
  • python310Packages.pyvo
  • python310Packages.qiskit
  • python310Packages.qiskit-machine-learning
  • python310Packages.reproject
  • python310Packages.runway-python
  • python310Packages.scikit-tda
  • python310Packages.scikitimage
  • python310Packages.slicedimage
  • python310Packages.spacy-transformers
  • python310Packages.sparse
  • python310Packages.spectral-cube
  • python310Packages.streamz
  • python310Packages.stumpy
  • python310Packages.stytra
  • python310Packages.sunpy
  • python310Packages.tensorflow (python310Packages.tensorflowWithoutCuda)
  • python310Packages.tensorflow-probability
  • python310Packages.tensorly
  • python310Packages.test-tube
  • python310Packages.tflearn
  • python310Packages.tifffile
  • python310Packages.tokenizers
  • python310Packages.transformers
  • python310Packages.umap-learn
  • python310Packages.zcs
  • python39Packages.apache-beam
  • python39Packages.aplpy
  • python39Packages.asdf
  • python39Packages.astroquery
  • python39Packages.batchgenerators
  • python39Packages.boxx
  • python39Packages.bpycv
  • python39Packages.caffe
  • python39Packages.casa-formats-io
  • python39Packages.clifford
  • python39Packages.dask
  • python39Packages.dask-gateway
  • python39Packages.dask-glm
  • python39Packages.dask-image
  • python39Packages.dask-jobqueue
  • python39Packages.dask-ml
  • python39Packages.dask-mpi
  • python39Packages.dask-yarn
  • python39Packages.datasets
  • python39Packages.datashader
  • python39Packages.db-dtypes
  • python39Packages.devito
  • python39Packages.diagrams
  • python39Packages.distributed
  • python39Packages.dremel3dpy
  • python39Packages.env-canada
  • python39Packages.glymur
  • python39Packages.handout
  • python39Packages.image-match
  • python39Packages.imagecorruptions
  • python39Packages.imageio
  • python39Packages.imgaug
  • python39Packages.intake
  • python39Packages.intake-parquet
  • python39Packages.ipwhl
  • python39Packages.moviepy
  • python39Packages.napari
  • python39Packages.napari-console
  • python39Packages.napari-svg
  • python39Packages.nats-py
  • python39Packages.pims
  • python39Packages.pyarrow
  • python39Packages.pyfftw
  • python39Packages.pyfzf
  • python39Packages.pyregion
  • python39Packages.pytest-astropy
  • python39Packages.pytest-astropy-header
  • python39Packages.pyvo
  • python39Packages.qiskit
  • python39Packages.qiskit-machine-learning
  • python39Packages.reproject
  • python39Packages.runway-python
  • python39Packages.scikitimage
  • python39Packages.slicedimage
  • python39Packages.spacy-transformers
  • python39Packages.sparse
  • python39Packages.spectral-cube
  • python39Packages.streamz
  • python39Packages.stumpy
  • python39Packages.stytra
  • python39Packages.sunpy
  • python39Packages.tensorly
  • python39Packages.test-tube
  • python39Packages.tifffile
  • python39Packages.tokenizers
  • python39Packages.transformers
  • python39Packages.zcs
  • qbec
  • qmk
  • qrcp
  • qsyncthingtray
  • quicktemplate
  • quorum
  • r53-ddns
  • rakkess
  • ran
  • rancher
  • ratt
  • rclone
  • rdap
  • redli
  • reflex
  • reftools
  • reg
  • regbot
  • regclient
  • regctl
  • regsync
  • rekor-cli
  • rekor-server
  • relic
  • remote-touchpad
  • renderizer
  • reposurgeon
  • reproxy
  • restic
  • restic-rest-server
  • restique
  • reviewdog
  • richgo
  • riseup-vpn
  • rmapi
  • rmfakecloud
  • robustirc-bridge
  • rootlesskit
  • round
  • roxctl
  • rtsp-simple-server
  • run
  • runc
  • s5cmd
  • safe
  • saml2aws
  • sammler
  • sampler
  • scaleway-cli
  • scc
  • scilla
  • scmpuff
  • scorecard
  • sd-local
  • sdlookup
  • seaweedfs
  • secrets-extractor
  • secretscanner
  • senpai
  • sensu-go-agent
  • sensu-go-backend
  • sensu-go-cli
  • senv
  • serfdom
  • shadowfox
  • shadowsocks-v2ray-plugin
  • shellhub-agent
  • shellz
  • shfmt
  • shhgit
  • shiori
  • shipyard
  • sift
  • skaffold
  • skate
  • skeema
  • skopeo
  • skydns
  • slack-term
  • slides
  • smug
  • snet
  • snowcat
  • snowcrash
  • snowflake
  • soft-serve
  • soju
  • sonobuoy
  • sops
  • sourcehut.buildsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.listssrht
  • sourcehut.metasrht
  • sourcehut.pagessrht
  • sourcehut.todosrht
  • spacevim
  • sparkleshare
  • spicetify-cli
  • spicy
  • spruce
  • sptlrx
  • spyre
  • sq
  • sqlc
  • sqls
  • srtrelay
  • ssb
  • ssh-chat
  • ssh-key-confirmer
  • ssh-to-age
  • ssh-to-pgp
  • sshchecker
  • sshportal
  • ssm-agent
  • ssmsh
  • starboard
  • starboard-octant-plugin
  • starlark
  • statik
  • stayrtr
  • steampipe
  • step-ca
  • step-cli
  • stern
  • storrent
  • streamlit
  • stripe-cli
  • subfinder
  • subjs
  • summon
  • sunpaper
  • sway-launcher-desktop
  • swaynag-battery
  • swego
  • sx-go
  • symfony-cli
  • syncthing
  • syncthing-discovery
  • syncthing-relay
  • syncthing-tray
  • systemd-journal2gelf
  • systrayhelper
  • sysz
  • tanka
  • tar2ext4
  • tartube
  • tartube-yt-dlp
  • tea
  • teensy-loader-cli
  • tegola
  • tektoncd-cli
  • telegraf
  • teleport
  • telepresence2
  • teler
  • tempo
  • tendermint
  • termdbms
  • terminal-parrot
  • termshark
  • terracognita
  • terraform
  • terraform-docs
  • terraform-full
  • terraform-inventory
  • terraform-ls
  • terraform-lsp
  • terraform-providers.aci
  • terraform-providers.acme
  • terraform-providers.age
  • terraform-providers.aiven
  • terraform-providers.akamai
  • terraform-providers.alicloud
  • terraform-providers.ansible
  • terraform-providers.archive
  • terraform-providers.auth0
  • terraform-providers.avi
  • terraform-providers.aviatrix
  • terraform-providers.aws
  • terraform-providers.azuread
  • terraform-providers.azurerm
  • terraform-providers.azurestack
  • terraform-providers.baiducloud
  • terraform-providers.bigip
  • terraform-providers.bitbucket
  • terraform-providers.buildkite
  • terraform-providers.checkly
  • terraform-providers.checkpoint
  • terraform-providers.ciscoasa
  • terraform-providers.cloudamqp
  • terraform-providers.cloudflare
  • terraform-providers.cloudfoundry
  • terraform-providers.cloudinit
  • terraform-providers.cloudscale
  • terraform-providers.constellix
  • terraform-providers.consul
  • terraform-providers.ct
  • terraform-providers.datadog
  • terraform-providers.dhall
  • terraform-providers.digitalocean
  • terraform-providers.dme
  • terraform-providers.dns
  • terraform-providers.dnsimple
  • terraform-providers.docker
  • terraform-providers.dome9
  • terraform-providers.elasticsearch
  • terraform-providers.equinix
  • terraform-providers.exoscale
  • terraform-providers.external
  • terraform-providers.fastly
  • terraform-providers.flexibleengine
  • terraform-providers.fortios
  • terraform-providers.gandi
  • terraform-providers.github
  • terraform-providers.gitlab
  • terraform-providers.google
  • terraform-providers.google-beta
  • terraform-providers.googleworkspace
  • terraform-providers.grafana
  • terraform-providers.gridscale
  • terraform-providers.hcloud
  • terraform-providers.helm
  • terraform-providers.heroku
  • terraform-providers.hetznerdns
  • terraform-providers.htpasswd
  • terraform-providers.http
  • terraform-providers.huaweicloud
  • terraform-providers.huaweicloudstack
  • terraform-providers.hydra
  • terraform-providers.ibm
  • terraform-providers.icinga2
  • terraform-providers.infoblox
  • terraform-providers.kafka
  • terraform-providers.kafka-connect
  • terraform-providers.keycloak
  • terraform-providers.ksyun
  • terraform-providers.kubectl
  • terraform-providers.kubernetes
  • terraform-providers.launchdarkly
  • terraform-providers.libvirt
  • terraform-providers.linuxbox
  • terraform-providers.local
  • terraform-providers.logicmonitor
  • terraform-providers.lxd
  • terraform-providers.mailgun
  • terraform-providers.matchbox
  • terraform-providers.metal
  • terraform-providers.minio
  • terraform-providers.mongodbatlas
  • terraform-providers.namecheap
  • terraform-providers.ncloud
  • terraform-providers.netlify
  • terraform-providers.newrelic
  • terraform-providers.nomad
  • terraform-providers.ns1
  • terraform-providers.nsxt
  • terraform-providers.null
  • terraform-providers.nutanix
  • terraform-providers.oci
  • terraform-providers.okta
  • terraform-providers.oktaasa
  • terraform-providers.opennebula
  • terraform-providers.openstack
  • terraform-providers.opentelekomcloud
  • terraform-providers.opsgenie
  • terraform-providers.ovh
  • terraform-providers.pagerduty
  • terraform-providers.panos
  • terraform-providers.pass
  • terraform-providers.postgresql
  • terraform-providers.powerdns
  • terraform-providers.rabbitmq
  • terraform-providers.rancher2
  • terraform-providers.random
  • terraform-providers.remote
  • terraform-providers.rundeck
  • terraform-providers.scaleway
  • terraform-providers.secret
  • terraform-providers.selectel
  • terraform-providers.sentry
  • terraform-providers.shell
  • terraform-providers.signalfx
  • terraform-providers.skytap
  • terraform-providers.snowflake
  • terraform-providers.sops
  • terraform-providers.spotinst
  • terraform-providers.stackpath
  • terraform-providers.statuscake
  • terraform-providers.sumologic
  • terraform-providers.tencentcloud
  • terraform-providers.tfe
  • terraform-providers.thunder
  • terraform-providers.time
  • terraform-providers.tls
  • terraform-providers.triton
  • terraform-providers.turbot
  • terraform-providers.ucloud
  • terraform-providers.utils
  • terraform-providers.vault
  • terraform-providers.vcd
  • terraform-providers.venafi
  • terraform-providers.vercel
  • terraform-providers.vpsadmin
  • terraform-providers.vra7
  • terraform-providers.vsphere
  • terraform-providers.vultr
  • terraform-providers.wavefront
  • terraform-providers.yandex
  • terraform_plugins_test
  • terraformer
  • terragrunt
  • terrascan
  • tewisay
  • textql
  • tf2pulumi
  • tfk8s
  • tflint
  • tfplugindocs
  • tfswitch
  • tgswitch
  • thanos
  • ticker
  • tile38
  • timescaledb-parallel-copy
  • timescaledb-tune
  • timew-sync-server
  • tinygo
  • tmsu
  • tmuxPlugins.extrakto
  • tmuxPlugins.tmux-fzf
  • todoist
  • topicctl
  • tracee
  • traefik
  • traefik-certs-dumper
  • traitor
  • trezor-suite
  • trezord
  • trickster
  • trillian
  • tsukae
  • ttchat
  • tts
  • tty-share
  • turbogit
  • tut
  • tz
  • ua
  • uchess
  • ultralist
  • umoci
  • uni
  • unifi-poller
  • unifiedpush-common-proxies
  • unipicker
  • unpackerr
  • unparam
  • up
  • urlhunter
  • uroboros
  • usql
  • v2ray
  • v2ray-domain-list-community
  • vale
  • vault
  • vcluster
  • velero
  • vendir
  • verifpal
  • versus
  • vgo2nix
  • vgrep
  • victoriametrics
  • viddy
  • vimPlugins.YouCompleteMe
  • vimPlugins.direnv-vim
  • vimPlugins.fzf-hoogle-vim
  • vimPlugins.fzf-lua
  • vimPlugins.fzf-vim
  • vimPlugins.fzfWrapper
  • vimPlugins.telescope-zoxide
  • vimPlugins.vim-fzf-coauthorship
  • vimPlugins.vim-go
  • vimPlugins.vim-hexokinase
  • vimPlugins.zoxide-vim
  • vndr
  • vouch-proxy
  • vscode-extensions.hashicorp.terraform
  • vscode-extensions.matklad.rust-analyzer
  • vsh
  • vultr
  • vultr-cli
  • waf-tester
  • wails
  • waitron
  • wakatime
  • wal-g
  • wallutils
  • wally-cli
  • waypoint
  • webanalyze
  • webcat
  • webdav
  • webhook
  • websocketd
  • webwormhole
  • wego
  • wgcf
  • wire
  • witness
  • woodpecker-agent
  • woodpecker-cli
  • woodpecker-server
  • wormhole-william
  • wp4nix
  • wprecon
  • wrap
  • writefreely
  • wuzz
  • xd
  • xmloscopy
  • xmonad-log
  • xurls
  • yajsv
  • yaml2json
  • yarn2nix
  • yascreen
  • ycmd
  • ydict
  • yeetgif
  • yggdrasil
  • yj
  • yq-go
  • ytarchive
  • ytfzf
  • ytt
  • yubihsm-connector
  • yubikey-agent
  • yubikey-touch-detector
  • zabbix.agent2
  • zabbixctl
  • zdns
  • zfs-prune-snapshots
  • zfsbackup
  • zgrab2
  • zk
  • zkar
  • zoekt
  • zoxide
  • zrepl
  • zsh-history

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review June 30, 2022 13:42
@SuperSandro2000 SuperSandro2000 requested a review from zowoq June 30, 2022 13:43
@rski
Copy link
Contributor

rski commented Jun 30, 2022

This looks fine to me, I'll let someone else give the final approval. I do think we can either fix or drop all the remaining packages, that can be left as future work over the next couple of weeks before 1.19 comes out

@SuperSandro2000 SuperSandro2000 force-pushed the go-1-18 branch 2 times, most recently from d8e04c5 to 0a80c84 Compare July 1, 2022 17:23
@SuperSandro2000
Copy link
Member Author

@ofborg eval

@zowoq
Copy link
Contributor

zowoq commented Jul 2, 2022

Have you checked all vendorSha256 hashes are reproducible with 1.18?

What are you planning to do about all darwin breakage on x86_64? Leaving contributors to figure out how to deal with dozens of broken and unfixable packages doesn't seem like a good idea. I'd suggest doing a hydra run just for x86_64-darwin and marking them as broken as part of this PR.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jul 4, 2022

Have you checked all vendorSha256 hashes are reproducible with 1.18?

I checked some and then determined that they won't change after none of my test examples changed.

Edit: Currently double checking with the current rebuilds. If we don't get a hash mismatch then this will be safe.

wget https://gist.githubusercontent.com/GrahamcOfBorg/41d3704882eceb3aa9de0c53f89bb298/raw/3c7143944161f0653dced2159bb4cd913a23d043/Changed%2520Paths
rg x86_64-linux Changed%20Paths | awk '{print $2}' | rg -v -e ^python310Packages -e ^python39Packages -e ^linuxKernel -e ^linuxPackages | xargs -I{} nix build --rebuild .#{}.go-modules

What are you planning to do about all darwin breakage on x86_64?

I pinged them in the darwin channel 5 days ago, 3 days ago and just now. So far I didn't receive any feedback. The Go 1.18 update is already stalled for a good amount of time and I don't want to make it another project held back by proprietary darwin. Lets wait a few days if someone provides feedback, otherwise I would just move ahead.

@SuperSandro2000
Copy link
Member Author

Here goes nothin!

@SuperSandro2000 SuperSandro2000 merged commit e32ba32 into NixOS:master Jul 15, 2022
@SuperSandro2000 SuperSandro2000 deleted the go-1-18 branch July 15, 2022 23:48
@rski
Copy link
Contributor

rski commented Jul 16, 2022

the nix-rebuild comment doesn't look right to me, the --rebuild flag seems to only be part of nix build

@SuperSandro2000
Copy link
Member Author

really? ufff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants