preload: init at 0.6.4 #141583

GustavoPeredo · 2021-10-13T22:21:40Z

Motivation for this change

I'm loving nixos! The only problem is that I've noticed some apps take longer to load, that's why I'm packaging preload, so programs can load faster.

NOTES:
1- This is my first package... I'm trying to learn here, so feel free to criticize as much as it is needed!
2- There are some, simingly, impossible to solve problems:
a) Upstream: The preload package can't create /var/preload/* and /var/log/preload.log, paths and files must be created/touched first (manually)
b) Indexing: I think indexing the entire nixstore would be too much for preload, it would be cool to be able to be able to get the paths of certain packages at build time, but I don't think this is possible. I'm currently indexing my home folder for my flatpaks, seem to be working well.
c) Systemd: preload comes with a for systemd, should I package it as a module as well then? Similar to
3- Where can I find more testing documentation? I'm having trouble finding resources

Things done

pkgs/misc/preload/default.nix

pkgs/top-level/all-packages.nix

pkgs/misc/preload/default.nix

Artturin · 2021-10-13T22:45:33Z

Please follow https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

the exeprefix and mapprefix will most likely need some changing in the module

ls /var/run/current-system/sw
bin  etc  lib  sbin  share

GustavoPeredo · 2021-10-14T05:34:27Z

Thanks, I'll be working on it

pkgs/misc/preload/default.nix

lucasew · 2021-10-14T18:02:54Z

BTW there is a guideline about naming PRs and commits

You can rename a commit using git commit --amend or git rebase --interactive. There are lots of tutorials and stuff about this.

If you are unsure about if the PR should be reviewed now or its work in progress you can mark it as draft.

Things can take a lot of time until merge, I already sent PRs that took over a month until merge.

Artturin · 2021-10-14T18:23:08Z

https://git-rebase.io/#fixup

GustavoPeredo · 2021-10-15T13:20:16Z

If you are unsure about if the PR should be reviewed now or its work in progress you can mark it as draft.

I'm pretty sure it is ready for a merge after I fix the . Can you link me to the guidelines for commits? I couldn't find any...

Thanks for the link! I tried following it, but I'm not sure it worked.

pkgs/misc/preload/default.nix

Artturin · 2021-10-15T13:31:06Z

I'm pretty sure it is ready for a merge after I fix the .

nixpkgs-fmt can be used to format the files

Can you link me to the guidelines for commits? I couldn't find any...

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

Artturin · 2021-10-15T14:47:17Z

all-packages.nix shouldn't be formatted with nixpkgs-fmt

Artturin · 2021-10-15T14:48:49Z

i would recommend that you do git reset --hard 7d88e70cb69e1d6c7924c88d8612bfd1b0d5e8ad to go back to the first commit (--hard will discard the newer commits, dont use --hard if you want to keep the changes, they will be staged)

GustavoPeredo · 2021-10-15T14:48:54Z

all-packages.nix shouldn't be formatted with nixpkgs-fmt

Yes, already reverted.

nixos/modules/programs/preload.nix

lucasew · 2021-11-06T23:11:56Z

A elegant way to do this is to generate the conf using the ini generator [1]. [1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/pkgs-lib/formats.nix#L77

…

On Sat, Nov 6, 2021, 19:37 Artturi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In nixos/modules/programs/preload.nix <#141583 (comment)>: > + configFile = pkgs.writeText "preload.conf" + '' + [model] + cycle = ${cfg.cycle} + usecorrelation = ${cfg.usecorrelation} + minsize = ${cfg.minsize} + memtotal = ${cfg.memtotal} + memfree = ${cfg.memfree} + memcached = ${cfg.memcached} + + [system] + doscan = ${cfg.doscan} + dopredict = ${cfg.dopredict} + autosave = ${cfg.autosave} + mapprefix = ${cfg.mapprefix} + exeprefix = ${cfg.exeprefix} + processes = ${cfg.processes} + sortstrategy = ${cfg.sortstrategy} + ''; Please use rfc42 style options. then we wont have to have so many separate options. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#141583 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXXO6GZWVDTTS2V5JF72ZLUKWU2DANCNFSM5F6H3D4Q> .

pkgs/top-level/all-packages.nix

GustavoPeredo · 2022-03-11T17:35:12Z

What is the state of this package ? This is one of the most important packages for nixos ecosystem

I think it's a matter of waiting, as @lucasew mentioned:

Things can take a lot of time until merge

But I'm not sure

Artturin · 2022-03-11T20:13:43Z

i will do some improvements and tests and force push the changes straight to your branch so remember to pull the changes correctly

Artturin · 2022-03-12T00:55:06Z

What is the state of this package ? This is one of the most important packages for nixos ecosystem

Considering the preload program hasn't received an update since 2013 i hope its not one of the most important packages for any distro

Someone needs to test this on a user system instead of a vm https://nixos.wiki/wiki/Nixpkgs/Reviewing_changes#Modules

bjornfor · 2022-03-12T09:06:29Z

I'm not sure exactly how preload works, but I feel this is relevant: NixOS/patchelf#357.

AFAIU, "shrinkwrapped" binaries will make the dynamic linker startup complexity O(n) instead of O(n^2). (And per-library lookup O(1) instead of O(n).)

baronleonardo · 2022-03-12T09:24:37Z

@Artturin if you have a better alternative (for improving the startup of apps and is an active project) tell me, and we could happily dismiss this and use the alternative.

GustavoPeredo · 2022-03-15T18:52:58Z

Someone needs to test this on a user system instead of a vm https://nixos.wiki/wiki/Nixpkgs/Reviewing_changes#Modules

I just installed it on a system of mine, seems to work just fine. What tests are needed?

Artturin · 2022-03-15T19:07:55Z

nixos/modules/programs/preload.nix

+            mapprefix = "/run/current-system/sw/share;/run/current-system/sw/lib;!/";
+            exeprefix = "!/run/current-system/sw/sbin/;/run/current-system/sw/bin;!/";


@GustavoPeredo are you sure it works fine? the things that i am most concerned about are these 2

They are following expected behavior, but it would be more useful if the nix store was added to these paths.

GustavoPeredo · 2022-03-15T20:23:15Z

There is now a problem with how the module writes the configuration file: It only adds modified values to the file (excludes defaults).

Does that mean the modules file has to be rewritten with each value as it's own mkOption? Like so:

settings.cycle = mkOption {
  type = ...;
  default = ...;
  description = ...;
};

Artturin · 2022-03-15T23:03:05Z

There is now a problem with how the module writes the configuration file: It only adds modified values to the file (excludes defaults).

Does that mean the modules file has to be rewritten with each value as it's own mkOption? Like so:
settings.cycle = mkOption {
  type = ...;
  default = ...;
  description = ...;
};

I think we just need to add
apply = recursiveUpdate default;

SuperSandro2000 · 2022-03-18T17:17:46Z

pkgs/misc/preload/default.nix

+  doCheck = false;
+
+  meta = with lib; {
+    homepage = "http://sourceforge.net/projects/preload";


Suggested change

homepage = "http://sourceforge.net/projects/preload";

homepage = "https://sourceforge.net/projects/preload/";

SuperSandro2000 · 2022-03-18T17:18:07Z

pkgs/misc/preload/default.nix

+
+  postPatch = ''
+    # "--logdir=/var/log/preload" failed with unknown option
+    substituteInPlace configure.ac \
+      --replace "logdir='\''${localstatedir}/log'" "logdir='\''${localstatedir}/log/preload'"
+  '';


Suggested change

postPatch = ''

# "--logdir=/var/log/preload" failed with unknown option

substituteInPlace configure.ac \

--replace "logdir='\''${localstatedir}/log'" "logdir='\''${localstatedir}/log/preload'"

'';

Were these formatting changes tested? I want to commit them, but had no time to test.

No but I am highly confident that they just work. Nix does not care about the ordering but it is very good practice to use somewhat standard ordering.

SuperSandro2000 · 2022-03-18T17:18:15Z

pkgs/misc/preload/default.nix

+  src = fetchurl {
+    url = "mirror://sourceforge/${pname}/${pname}-${version}.tar.gz";
+    sha256 = "d0a558e83cb29a51d9d96736ef39f4b4e55e43a589ad1aec594a048ca22f816b";
+  };


Suggested change

};

};

postPatch = ''

# "--logdir=/var/log/preload" failed with unknown option

substituteInPlace configure.ac \

--replace "logdir='\''${localstatedir}/log'" "logdir='\''${localstatedir}/log/preload'"

'';

SuperSandro2000 · 2022-03-18T17:18:23Z

pkgs/misc/preload/default.nix

+  version = "0.6.4";
+
+  src = fetchurl {
+    url = "mirror://sourceforge/${pname}/${pname}-${version}.tar.gz";


Suggested change

url = "mirror://sourceforge/${pname}/${pname}-${version}.tar.gz";

url = "mirror://sourceforge/preload/preload-${version}.tar.gz";

SuperSandro2000 · 2022-03-18T17:18:36Z

pkgs/misc/preload/default.nix

+{
+  lib,
+  stdenv,
+  fetchurl,
+  glib,
+  pkg-config,
+  help2man,
+  autoreconfHook,
+}:
+stdenv.mkDerivation rec {


Suggested change

{

lib,

stdenv,

fetchurl,

glib,

pkg-config,

help2man,

autoreconfHook,

}:

stdenv.mkDerivation rec {

{ lib

, stdenv

, fetchurl

, glib

, pkg-config

, help2man

, autoreconfHook

}:

stdenv.mkDerivation rec {

SuperSandro2000 · 2022-03-18T17:19:10Z

nixos/modules/programs/preload.nix

+{
+  config,
+  lib,
+  pkgs,
+  ...
+}:
+with lib; let
+  cfg = config.programs.preload;
+  settingsFormat = pkgs.formats.ini {};
+  configFile = settingsFormat.generate "preload.conf" cfg.settings;
+in {


Suggested change

{

config,

lib,

pkgs,

...

}:

with lib; let

cfg = config.programs.preload;

settingsFormat = pkgs.formats.ini {};

configFile = settingsFormat.generate "preload.conf" cfg.settings;

in {

{ config

, lib

, pkgs

, ...

}:

with lib;

let

cfg = config.programs.preload;

settingsFormat = pkgs.formats.ini {};

configFile = settingsFormat.generate "preload.conf" cfg.settings;

in {

Princemachiavelli · 2023-07-12T00:00:37Z

nixos/modules/programs/preload.nix

+        type = types.submodule {
+          freeformType = settingsFormat.type;
+        };
+        apply = recursiveUpdate default;


default can't be referenced here. Just moving it to the let block works.

Also settings.default should be {} to allow just using the default config.

AndersonTorres · 2023-11-29T23:43:33Z

Closing as dead and with conflicts.

ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 13, 2021

Artturin reviewed Oct 13, 2021

View reviewed changes

pkgs/misc/preload/default.nix Outdated Show resolved Hide resolved

Artturin reviewed Oct 13, 2021

View reviewed changes

pkgs/misc/preload/default.nix Outdated Show resolved Hide resolved

Artturin reviewed Oct 13, 2021

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

pkgs/misc/preload/default.nix Outdated Show resolved Hide resolved

lucasew reviewed Oct 14, 2021

View reviewed changes

pkgs/misc/preload/default.nix Outdated Show resolved Hide resolved

GustavoPeredo force-pushed the preload branch from ce49bc7 to e949570 Compare October 15, 2021 13:12

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 15, 2021

GustavoPeredo changed the title ~~Preload~~ preload: 0.6.4 Oct 15, 2021

Artturin reviewed Oct 15, 2021

View reviewed changes

pkgs/misc/preload/default.nix Outdated Show resolved Hide resolved

ofborg bot added ofborg-internal-error Ofborg encountered an error 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 15, 2021

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 15, 2021

cole-h removed the ofborg-internal-error Ofborg encountered an error label Oct 21, 2021

Artturin reviewed Nov 6, 2021

View reviewed changes

nixos/modules/programs/preload.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Nov 7, 2021

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

Artturin self-requested a review March 11, 2022 19:57

Artturin self-assigned this Mar 11, 2022

Artturin force-pushed the preload branch from 76b72da to 9f291a0 Compare March 12, 2022 00:49

Artturin force-pushed the preload branch from 9f291a0 to 3c2be2d Compare March 12, 2022 00:56

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 labels Mar 12, 2022

Artturin reviewed Mar 15, 2022

View reviewed changes

preload: init at 0.6.4

ed2b4b3

Artturin force-pushed the preload branch from 3c2be2d to ed2b4b3 Compare March 17, 2022 19:26

SuperSandro2000 reviewed Mar 18, 2022

View reviewed changes

onny marked this pull request as draft September 6, 2022 13:42

Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023

Princemachiavelli reviewed Jul 12, 2023

View reviewed changes

AndersonTorres closed this Nov 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

preload: init at 0.6.4 #141583

preload: init at 0.6.4 #141583

GustavoPeredo commented Oct 13, 2021 •

edited

Loading

Artturin commented Oct 13, 2021 •

edited

Loading

GustavoPeredo commented Oct 14, 2021

lucasew commented Oct 14, 2021

Artturin commented Oct 14, 2021

GustavoPeredo commented Oct 15, 2021

Artturin commented Oct 15, 2021

Artturin commented Oct 15, 2021 •

edited

Loading

Artturin commented Oct 15, 2021 •

edited

Loading

GustavoPeredo commented Oct 15, 2021

lucasew commented Nov 6, 2021 via email

GustavoPeredo commented Mar 11, 2022

Artturin commented Mar 11, 2022

Artturin commented Mar 12, 2022

bjornfor commented Mar 12, 2022

baronleonardo commented Mar 12, 2022

GustavoPeredo commented Mar 15, 2022

Artturin Mar 15, 2022

GustavoPeredo Mar 15, 2022 •

edited

Loading

GustavoPeredo commented Mar 15, 2022

Artturin commented Mar 15, 2022

SuperSandro2000 Mar 18, 2022

SuperSandro2000 Mar 18, 2022

GustavoPeredo Mar 24, 2022 •

edited

Loading

SuperSandro2000 Mar 26, 2022

SuperSandro2000 Mar 18, 2022

SuperSandro2000 Mar 18, 2022

SuperSandro2000 Mar 18, 2022

SuperSandro2000 Mar 18, 2022

Princemachiavelli Jul 12, 2023

AndersonTorres commented Nov 29, 2023

		mapprefix = "/run/current-system/sw/share;/run/current-system/sw/lib;!/";
		exeprefix = "!/run/current-system/sw/sbin/;/run/current-system/sw/bin;!/";

	homepage = "http://sourceforge.net/projects/preload";
	homepage = "https://sourceforge.net/projects/preload/";

	url = "mirror://sourceforge/${pname}/${pname}-${version}.tar.gz";
	url = "mirror://sourceforge/preload/preload-${version}.tar.gz";

preload: init at 0.6.4 #141583

preload: init at 0.6.4 #141583

Conversation

GustavoPeredo commented Oct 13, 2021 • edited Loading

Motivation for this change

Things done

Artturin commented Oct 13, 2021 • edited Loading

GustavoPeredo commented Oct 14, 2021

lucasew commented Oct 14, 2021

Artturin commented Oct 14, 2021

GustavoPeredo commented Oct 15, 2021

Artturin commented Oct 15, 2021

Artturin commented Oct 15, 2021 • edited Loading

Artturin commented Oct 15, 2021 • edited Loading

GustavoPeredo commented Oct 15, 2021

lucasew commented Nov 6, 2021 via email

GustavoPeredo commented Mar 11, 2022

Artturin commented Mar 11, 2022

Artturin commented Mar 12, 2022

bjornfor commented Mar 12, 2022

baronleonardo commented Mar 12, 2022

GustavoPeredo commented Mar 15, 2022

Choose a reason for hiding this comment

GustavoPeredo Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

GustavoPeredo commented Mar 15, 2022

Artturin commented Mar 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GustavoPeredo Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndersonTorres commented Nov 29, 2023

GustavoPeredo commented Oct 13, 2021 •

edited

Loading

Artturin commented Oct 13, 2021 •

edited

Loading

Artturin commented Oct 15, 2021 •

edited

Loading

Artturin commented Oct 15, 2021 •

edited

Loading

GustavoPeredo Mar 15, 2022 •

edited

Loading

GustavoPeredo Mar 24, 2022 •

edited

Loading