Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovimUtils: pynvim is disabled with python < 3.4 #121419

Closed
wants to merge 1 commit into from

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Fixes neovim build, neovim was failing since 2a00e53

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented May 1, 2021

nix build pythonPackages.pynvim -f channel:nixos-unstable seems to build ?
This is going to break the setup for users running remote python2 plugins (I dont know any but still)

EDIT: that's recent, see #121419 for a better PR maybe

@SCOTT-HAMILTON
Copy link
Contributor Author

SCOTT-HAMILTON commented May 2, 2021

nix build pythonPackages.pynvim -f channel:nixos-unstable seems to build ?
This is going to break the setup for users running remote python2 plugins (I dont know any but still)

EDIT: that's recent, see #121419 for a better PR maybe

As said above, the breaking commit is 2a00e53. It has been pushed 2 days ago.

Try running : nix build -f channel:nixpkgs-unstable pythonPackages.pynvim to reproduce the evaluation issue.

And if python2 plugin users have an issue, it's because of this commit, not this PR.

@teto
Copy link
Member

teto commented May 2, 2021

sry I copy/pasted the wrong PR, I meant can we close this PR in favor of #121339 (comment) ?

@SCOTT-HAMILTON
Copy link
Contributor Author

Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants