Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: configurable LLVM_ENABLE_ASSERTIONS flag #338065

Closed
cospectrum opened this issue Aug 29, 2024 · 3 comments
Closed

Feature Request: configurable LLVM_ENABLE_ASSERTIONS flag #338065

cospectrum opened this issue Aug 29, 2024 · 3 comments

Comments

@cospectrum
Copy link

cospectrum commented Aug 29, 2024 •
edited
Loading

Description

LLVM_ENABLE_ASSERTIONS variable can be turned ON in Release mode, and as far as I know, it's not the same as CMAKE_BUILD_TYPE=Debug.
Feature can be implemented with backward compatibility in libllvm.
This feature will allow you to use LLVM in both fast and safe mode.
@cospectrum cospectrum changed the title Feature Request: configurable LLVM_ENABLE_ASSERTIONS Feature Request: configurable LLVM_ENABLE_ASSERTIONS flag Oct 9, 2024
@cospectrum
Copy link
Author

I noticed that #342040 introduced the way to add extra cmake flags to llvm in unstable branch.
So now it should possible to pass LLVM_ENABLE_ASSERTIONS or any other cmake flag and it will be applied without problems. Am I right? @pwaller

@pwaller
Copy link
Contributor

pwaller commented Oct 10, 2024

Yep, should work.

@cospectrum
Copy link
Author

cospectrum commented Oct 10, 2024 •
edited
Loading

Yep, should work.

In that case, thank YOU very much! I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pwaller @cospectrum