Build failure: awscli2

[Fuuzetsu]

Steps To Reproduce

Steps to reproduce the behavior:

On current master, awscli2 fails due to failing tests.

$ git rev-parse origin/master
56838849131f63999fd2afe5fb629c7a680ff405
$ nix -L build .?ref=56838849131f63999fd2afe5fb629c7a680ff405#awscli2 --no-link

1. build X

Build log

$ nix log .?ref=56838849131f63999fd2afe5fb629c7a680ff405#awscli2 |

Log here: https://gist.github.com/Fuuzetsu/9577fc4594aa6ed654fa500d84c6b293

The failing test is

FAILED tests/unit/customizations/cloudtrail/test_validation.py::TestSha256RSADigestValidator::test_validates_digests - ValueError: key_size must be at least 1024-bits.

Notify maintainers

@bhipple @davegallant @bryanasdev000 @devusb @anthonyroussel

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[shana@aya:~/programming/nixpkgs]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.44, NixOS, 24.11 (Vicuna), 24.11.git.0039426728da`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

---

Add a 👍 reaction to issues you find important.

[Fuuzetsu]

Last update was at #330602

It looks like it worked at the time:

https://logs.ofborg.org/?key=nixos/nixpkgs.330602&attempt_id=f803086a-f564-442b-bb67-a92405ddb636

If I run the code from the PR commit directly, the build passes.

[shana@aya:~/programming/nixpkgs]$ nix log .?ref=8690f8722d23a388d96c15fe6d76472d9a954db2#awscli2 | tail
warning: AWS error fetching 'nix-cache-info': The specified bucket does not exist
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============ 4098 passed, 1 skipped, 2 warnings in 70.95s (0:01:10) ============
Finished executing pytestCheckPhase
pytestCheckPhase completed in 1 minutes 13 seconds
@nix { "action": "setPhase", "phase": "pytestcachePhase" }
Running phase: pytestcachePhase
@nix { "action": "setPhase", "phase": "pytestRemoveBytecodePhase" }
Running phase: pytestRemoveBytecodePhase

[Fuuzetsu]

Reverting the commit and trying to build again with the current master does not fix the problem. Presumably some dependency update broke it. I'll try to bisect it down.

[Fuuzetsu]

3a6026ad2368c9f214eae6856c0eb7fb013e1577 is the first bad commit
commit 3a6026ad2368c9f214eae6856c0eb7fb013e1577 (HEAD)
Author: Martin Weinelt <[email protected]>
Date:   Sun Jul 21 16:15:57 2024 +0200

    python312Packages.cryptography: 42.0.8 -> 43.0.0
    
    https://cryptography.io/en/latest/changelog/#v43-0-0

 pkgs/development/python-modules/cryptography/default.nix | 37 ++++++++++++++++---------------------
 pkgs/development/python-modules/cryptography/vectors.nix |  2 +-
 2 files changed, 17 insertions(+), 22 deletions(-)

#328927

cc @mweinelt

[andrevmatos]

Maybe fixed by aws/aws-cli#8838 ?

[Fuuzetsu]

Maybe fixed by aws/aws-cli#8838 ?

That looks correct. Looks like it has been open for 2 weeks: should we cherry pick the patch or disable the test(s)?

[petrzjunior]

I've found this problem yesterday and I confirm, that applying the patch from aws/aws-cli#8838 fixes the build.