Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: stm32loader #332715

Closed
sgrb opened this issue Aug 6, 2024 · 1 comment · Fixed by #333676
Closed

Build failure: stm32loader #332715

sgrb opened this issue Aug 6, 2024 · 1 comment · Fixed by #333676

Comments

@sgrb
Copy link
Contributor

sgrb commented Aug 6, 2024

Build fails on running tests

Steps To Reproduce

Steps to reproduce the behavior:
nix build github:NixOS/nixpkgs/3d19c4d6edec2e735d518fe9ab2b81bd8092bbb5#legacyPackages.x86_64-linux.stm32loader

Build log

=========================== short test summary info ============================
FAILED tests/unit/test_bootloader.py::test_get_uid_for_known_family_reads_at_correct_address[F1] - AttributeError: 'called_once_with' is not a valid assertion. Use a spec for...
FAILED tests/unit/test_bootloader.py::test_get_uid_for_known_family_reads_at_correct_address[F3] - AttributeError: 'called_once_with' is not a valid assertion. Use a spec for...
FAILED tests/unit/test_bootloader.py::test_get_uid_for_known_family_reads_at_correct_address[F7] - AttributeError: 'called_once_with' is not a valid assertion. Use a spec for...
========================= 3 failed, 46 passed in 0.82s =========================

Full log: https://gist.github.com/sgrb/0079a4967e882bff098cfc8c9ffe53e6

Notify maintainers

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.41, NixOS, 24.11 (Vicuna), 24.11.20240719.1d9c2c9`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `""`
 - channels(slava): `""`
 - nixpkgs: `/etc/nix/nixpkgs`

Add a 👍 reaction to issues you find important.

@ghpzin
Copy link
Contributor

ghpzin commented Aug 6, 2024

Hydra builds (never build successfully on python 3.12):
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.python312Packages.stm32loader.x86_64-linux
https://hydra.nixos.org/build/267610720

Upstream seems to be have been hit by this:
python/cpython#100690
which was made into an error with python 3.12

This assert was always true:
https://github.com/florisla/stm32loader/blob/c56da3ddf552df033f5445963b0a0fce0259125f/tests/unit/test_bootloader.py#L216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants