Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx module should allow config passed in as path #30475

Open
copumpkin opened this issue Oct 16, 2017 · 2 comments
Open

Nginx module should allow config passed in as path #30475

copumpkin opened this issue Oct 16, 2017 · 2 comments
Labels
0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS

Comments

@copumpkin
Copy link
Member

In general, it's much more pleasant to go from a string to a path than the other way around, since builtins.readFile then forces import-from-derivation and other unpleasantness. The nginx module today unfortunately expects config and appendConfig to be strings, which means that if my config file comes from a derivation (e.g., pkgs.substituteAll) tha forces me to build during evaluation. It doesn't seem terribly hard to support the other use case by deferring the writeText a bit more.

@copumpkin copumpkin added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 16, 2017
@stale
Copy link

stale bot commented Jun 5, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2020
@tomodachi94 tomodachi94 added the 0.kind: enhancement Add something new label Nov 7, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 7, 2024
@tomodachi94
Copy link
Member

cc @RaitoBezarius @fpletz, who are maintainers on the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Projects
None yet
Development

No branches or pull requests

2 participants