git SSL issues with recent Nix on darwin

[domenkozar]

$ git pull
fatal: unable to access 'https://github.com/....git/': error setting certificate verify locations:
  CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: none
$ nix-env --version
nix-env (Nix) 1.11.7
$ which git
/Users/admin/.nix-profile/bin/git

Workaround:

$ SSL_CERT_FILE=$NIX_SSL_CERT_FILE git pull

cc @edolstra did we patch git?

[edolstra]

I think you need this patch: 942dbf8

[domenkozar]

It seems it never hit master: 811b876

https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/version-management/git-and-tools/git/ssl-cert-file.patch

[domenkozar]

@edolstra any objections using that patch (minus the print line)?

[shanemikel]

I just did an upgrade and It's broken.

Has the darwin support status changed?
I'm on nixpkgs-unstable channel

[globin]

This only affects darwin, right? I don't see a reason for the milestone then? :)

[domenkozar]

I'd like to fix it for release as well.

[LnL7]

I think so, I'm pretty sure the nixos modules set SSL_CERT_FILE but a linux single user install might also have issues.

[domenkozar]

This is now in staging, once built also needs to go to master and 17.03

cc @globin

[domenkozar]

It has been fixed in 17.03, but it's still in staging for master.

[LnL7]

I thought all of those cert related changes where in master now, with the last staging merge.

[domenkozar]

This is now on master and 17.03.