Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically open ports for matrix synapse server #22328

Closed
moretea opened this issue Jan 31, 2017 · 2 comments
Closed

Automatically open ports for matrix synapse server #22328

moretea opened this issue Jan 31, 2017 · 2 comments

Comments

@moretea
Copy link
Contributor

moretea commented Jan 31, 2017

Add a openPortsInFirewall option, with a default of true. It's pretty pointless to run a matrix server without connecting to other ones.

@copumpkin
Copy link
Member

This could be said about most of our services. It'd be nice if we could abstract over common service patterns like the enable option and port settings. I.e., some sort of function that produces the { config, ... }: { options = ...; config = ... } structure but takes care of automatically managing common repetitive crap like this.

Ideal to me feels like:

  1. Global setting, firewall.openServicePortsByDefault, defaulting to false
  2. Every service (via some abstraction over services) has a service.foo.openPorts, with a default value of firewall.openServicePortsByDefault
  3. Now if you set firewall.openServicePortsByDefault = true;, services open ports by default, but you can opt individual services out by setting service.foo.openPorts = false;

Either way see #19504

@FRidh
Copy link
Member

FRidh commented Feb 8, 2017

Closing because this is, as pointed out by @copumpkin, discussed in #19504.

@FRidh FRidh closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants