Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have hydra mark available PRs #19773

Closed
NeQuissimus opened this issue Oct 22, 2016 · 8 comments
Closed

Have hydra mark available PRs #19773

NeQuissimus opened this issue Oct 22, 2016 · 8 comments

Comments

@NeQuissimus
Copy link
Member

Is there a way we could have Hydra mark PRs with a label or something similar once the change has been released to the targeted channel.

Say I have a PR in master, Hydra would over time add labels for available: nixpkgs-unstable, available: nixos-unstable-small and available: nixos-unstable. Similarly, changes to 16.09 would eventually tagged with labels for the two channels for it.

@vcunat
Copy link
Member

vcunat commented Oct 22, 2016

That's just about git branch --contains PR-commit run on nixpkgs-channels repo. Maybe it's possible to make github show such info, perhaps some bot can do it.

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Oct 22, 2016

But then we would have to go across repos, would we not? Grab master on nixpkgs-channels and see if a PR from nixpkgs is in there?!
I figured it would be easier to have Hydra do that since it already touches both repos.

@vcunat
Copy link
Member

vcunat commented Oct 22, 2016

Pushing to git and commenting on issues (or labeling them) are rather different things, but yes, it shouldn't be difficult to implement as part of the channel-update mechanism run on Hydra.

@domenkozar
Copy link
Member

I think it's better to zoom out here and think about what information exactly you need and then we can discuss the implementation.

@NeQuissimus
Copy link
Member Author

I was thinking about this in the context of updates that fix vulnerabilities. Once we commit the fix, it still takes a little while until users can pull the update off the channels. How do users know when the update is available?

@domenkozar
Copy link
Member

I'd then propose to close this and continue in #13515

@NeQuissimus
Copy link
Member Author

OK, sure. I had simply hoped for a more general solution.

@vcunat
Copy link
Member

vcunat commented Nov 19, 2016

Hmm, there's a relatively easy way to find out, e.g. click link NixOS/nixpkgs-channels@c2922a9 and you see a list of channels containing the commit in there. It's not perfect, e.g. this one doesn't show nixos-unstable-small, presumably because it points to exactly the same commit as nixos-unstable ATM. (EDIT: and you get page not found for commits not in any channel yet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants