-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have hydra mark available PRs #19773
Comments
That's just about |
But then we would have to go across repos, would we not? Grab master on |
Pushing to git and commenting on issues (or labeling them) are rather different things, but yes, it shouldn't be difficult to implement as part of the channel-update mechanism run on Hydra. |
I think it's better to zoom out here and think about what information exactly you need and then we can discuss the implementation. |
I was thinking about this in the context of updates that fix vulnerabilities. Once we commit the fix, it still takes a little while until users can pull the update off the channels. How do users know when the update is available? |
I'd then propose to close this and continue in #13515 |
OK, sure. I had simply hoped for a more general solution. |
Hmm, there's a relatively easy way to find out, e.g. click link NixOS/nixpkgs-channels@c2922a9 and you see a list of channels containing the commit in there. It's not perfect, e.g. this one doesn't show nixos-unstable-small, presumably because it points to exactly the same commit as nixos-unstable ATM. (EDIT: and you get page not found for commits not in any channel yet.) |
Is there a way we could have Hydra mark PRs with a label or something similar once the change has been released to the targeted channel.
Say I have a PR in master, Hydra would over time add labels for
available: nixpkgs-unstable
,available: nixos-unstable-small
andavailable: nixos-unstable
. Similarly, changes to 16.09 would eventually tagged with labels for the two channels for it.The text was updated successfully, but these errors were encountered: