Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for nixos-install. #159773

Closed
YellowOnion opened this issue Feb 13, 2022 · 1 comment
Closed

Write tests for nixos-install. #159773

YellowOnion opened this issue Feb 13, 2022 · 1 comment
Labels
0.kind: bug Something is broken 2.status: duplicate This is a duplicate of another issue or PR 6.topic: testing Tooling for automated testing of packages and modules

Comments

@YellowOnion
Copy link
Contributor

Describe the bug

On several occasions I've had issues where the installer doesn't work on unstable, trying to repair a broken system and have a core package break under this scenario, especially reverting to stable and compile a new custom kernel just to get my system to boot again is really frustrating and a waste of time.

see:
#156121

and:

copying channel...
installing the boot loader...
setting up /etc...
Running in chroot, ignoring request.
Copied "/nix/store/24ljibki63lxk0m11qnw8fh9smh64g3x-systemd-249.7/lib/systemd/boot/efi/systemd-bootx64.efi" to "/boot/EFI/systemd/systemd-bootx64.efi".
Copied "/nix/store/24ljibki63lxk0m11qnw8fh9smh64g3x-systemd-249.7/lib/systemd/boot/efi/systemd-bootx64.efi" to "/boot/EFI/BOOT/BOOTX64.EFI".
Random seed file /boot/loader/random-seed successfully written (512 bytes).
Created EFI boot entry "Linux Boot Manager".
mktemp: failed to create file via template ‘/mnt/tmp.p7wN2peYyL/tmp.XXXXXXXXXX’: No such file or directory
Traceback (most recent call last):
  File "/nix/store/g66xbwwxlxbxnfq6i1zzdc2nbqydsw28-systemd-boot", line 305, in <module>
    main()
  File "/nix/store/g66xbwwxlxbxnfq6i1zzdc2nbqydsw28-systemd-boot", line 293, in main
    subprocess.check_call("/nix/store/si4frm8y336b00animvm77mkmqmc3k9d-copy-extra-files")
  File "/nix/store/afi0ysqw20yiiw2gr2d28dx40bc4ddf8-python3-3.9.10/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/nix/store/si4frm8y336b00animvm77mkmqmc3k9d-copy-extra-files' returned non-zero exit status 1.
@YellowOnion YellowOnion added the 0.kind: bug Something is broken label Feb 13, 2022
@veprbl veprbl added the 6.topic: testing Tooling for automated testing of packages and modules label Feb 13, 2022
@roberth
Copy link
Member

roberth commented Feb 23, 2022

We have tests for NixOS installation, in nixos/tests/installer.nix.
All except grub1 (legacy?) currently pass on hydra (search nixos.tests.installer)
You can't write a test without resolving your issue, and you shouldn't resolve your issue without a test, so I don't see the purpose of this issue.

I also want more and better tests, but I don't think this issue is going to help with that.

Closing as duplicate of #156212

@roberth roberth closed this as completed Feb 23, 2022
@roberth roberth added the 2.status: duplicate This is a duplicate of another issue or PR label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 2.status: duplicate This is a duplicate of another issue or PR 6.topic: testing Tooling for automated testing of packages and modules
Projects
None yet
Development

No branches or pull requests

3 participants