Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix for node packages #1471

Closed
chaoflow opened this issue Jan 7, 2014 · 6 comments
Closed

prefix for node packages #1471

chaoflow opened this issue Jan 7, 2014 · 6 comments
Assignees

Comments

@chaoflow
Copy link
Member

chaoflow commented Jan 7, 2014

For perl and python we prefix packages. This should also be done for node packages. An exception might be applications written in node that are installed for the sake of having the application instead of the node package available. See #1466

@domenkozar
Copy link
Member

+1 from me

@domenkozar
Copy link
Member

See 2f11bc4

@shlevy
Copy link
Member

shlevy commented Jan 7, 2014

I guess given 2f11bc4 this is now inevitable. I'll modify npm2nix to add a marker if a package contains any binaries and use that to determine if packages should get the node- prefix then add back the recurseIntoAttrs

@ghost ghost assigned shlevy Jan 7, 2014
@chaoflow
Copy link
Member Author

chaoflow commented Jan 7, 2014

I'm not sure whether having binaries is enough to count as an "application". nose for example is a python test tool and setuptools ships with easy_install and a couple more binaries. Both I would like to see as python2.7-nose and python2.7-setuptools, not without a prefix. Whereas offlineimap and afew, two tools concerned with handling emails, I would like to see without prefix.

@shlevy
Copy link
Member

shlevy commented Jan 7, 2014

Well if it turns out to be a problem we can just do them all with the node prefix, but seems like a good place to start.

@shlevy
Copy link
Member

shlevy commented Feb 3, 2014

Fixed in 3bec816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants