Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark failing to build packages in 20.09 as broken #100111

Closed
worldofpeace opened this issue Oct 9, 2020 · 10 comments
Closed

Mark failing to build packages in 20.09 as broken #100111

worldofpeace opened this issue Oct 9, 2020 · 10 comments
Assignees
@jonringer
Labels
0.kind: bug Something is broken 6.topic: release process Issues or PRs which are parts of the NixOS release process
Milestone
20.09

Comments

@worldofpeace
Copy link
Contributor

Describe the bug
As Per ZERO Hydra Failure #80379, we're supposed to mark every package that fails to build on the stable branch as broken. People can backport fixes to unbreak packages after we cut the final release. This is best done all at once semi-automatically, so this will be a task for @NixOS/nixos-release-managers to perform when they are about to cut the final release. (in a PR please ❗ )
@worldofpeace worldofpeace added the 0.kind: bug Something is broken label Oct 9, 2020
@worldofpeace worldofpeace added this to the 20.09 milestone Oct 9, 2020
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Oct 9, 2020 •
edited
Loading

@petabyteboy made https://github.com/NixOS/nixpkgs/blob/master/pkgs/common-updater/scripts/mark-broken for us last release so we can try the script out this release. Having this happen on a regular automated basis would be nicer, though.

@das-g
Copy link
Member

das-g commented Oct 9, 2020

Will it be possible to ping the maintainers of the respective packages?

@worldofpeace
Copy link
Contributor Author

Will it be possible to ping the maintainers of the respective packages?

Manually, probably humanly impossible 😁 If they are in nixpkgs-maintainers ofborg should handle it.

@jonringer
Copy link
Contributor

jonringer commented Oct 12, 2020 •
edited
Loading

Will it be possible to ping the maintainers of the respective packages?

I would also say that the appropriate time to fix a package was during ZHF.

That being said, fixes are always welcome.

Packages that fail to build can be found by maintainer by running:

$ nix build -f ./maintainers/scripts/build.nix --argstr maintainer <name>

example:

$ nix build -f ./maintainers/scripts/build.nix --argstr maintainer jonringer
[128 copied (706.5 MiB), 26.1 MiB DL]

@jonringer jonringer self-assigned this Oct 19, 2020
@cole-h
Copy link
Member

cole-h commented Oct 23, 2020

If they are in nixpkgs-maintainers ofborg should handle it.

ofborg only requests reviews from a maximum of 9 people; else, it skips this. So, maybe not.

https://github.com/NixOS/ofborg/blob/cc18d6626ce93c4b8310d5b72a88a73bec1e1466/ofborg/src/tasks/eval/nixpkgs.rs#L590

@das-g
Copy link
Member

das-g commented Oct 23, 2020

If they are in nixpkgs-maintainers ofborg should handle it.

ofborg only requests reviews from a maximum of 9 people; else, it skips this. So, maybe not.

https://github.com/NixOS/ofborg/blob/cc18d6626ce93c4b8310d5b72a88a73bec1e1466/ofborg/src/tasks/eval/nixpkgs.rs#L590

@grahamc What's the reason for that limit? Could it be lifted or would that lead to problems?

@cole-h
Copy link
Member

cole-h commented Oct 23, 2020 •
edited
Loading

The reason is so we don't ping the entire list when staging and staging-next PRs are opened.

EDIT: And there's probably an API limitation somewhere in there.

@cole-h cole-h mentioned this issue Oct 26, 2020
Merged
10 tasks
@cole-h cole-h added the 6.topic: release process Issues or PRs which are parts of the NixOS release process label Oct 26, 2020
@jonringer
Copy link
Contributor

This is partially done. Only linux modules should be left:

linuxPackages_5_8.batman_adv
linuxPackages_5_8.chipsec
linuxPackages_5_8.exfat-nofuse
linuxPackages_5_8.mxu11x0
linuxPackages_5_8.ndiswrapper
linuxPackages_5_8.netatop
linuxPackages_5_8.nvidiabl
linuxPackages_5_8.openafs_1_8
linuxPackages_5_8.r8168
linuxPackages_5_8.rtl8814au
linuxPackages_5_8.rtl8821au
linuxPackages_5_8.rtl88xxau-aircrack
linuxPackages_5_8.rtlwifi_new
linuxPackages_5_9.anbox
linuxPackages_5_9.batman_adv
linuxPackages_5_9.chipsec
linuxPackages_5_9.dpdk
linuxPackages_5_9.ena
linuxPackages_5_9.evdi
linuxPackages_5_9.exfat-nofuse
linuxPackages_5_9.mxu11x0
linuxPackages_5_9.ndiswrapper
linuxPackages_5_9.netatop
linuxPackages_5_9.nvidiabl
linuxPackages_5_9.openafs_1_8
linuxPackages_5_9.r8168
linuxPackages_5_9.rtl8814au
linuxPackages_5_9.rtl8821au
linuxPackages_5_9.rtl88xxau-aircrack
linuxPackages_5_9.rtlwifi_new
linuxPackages_5_9.virtualbox
linuxPackages_5_9.virtualboxGuestAdditions
linuxPackages_5_9.zfs
linuxPackages_5_9.zfsStable
linuxPackages_hardened.mxu11x0
linuxPackages_hardened.ndiswrapper
linuxPackages_hardened.openafs_1_8
linuxPackages_hardened.r8168
linuxPackages_hardened.rtl8814au
linuxPackages_hardened.rtl8821au
linuxPackages_hardened.rtlwifi_new
linuxPackages_latest-libre.anbox
linuxPackages_latest-libre.batman_adv
linuxPackages_latest-libre.chipsec
linuxPackages_latest-libre.exfat-nofuse
linuxPackages_latest-libre.mxu11x0
linuxPackages_latest-libre.ndiswrapper
linuxPackages_latest-libre.netatop
linuxPackages_latest-libre.nvidiabl
linuxPackages_latest-libre.openafs_1_8
linuxPackages_latest-libre.r8168
linuxPackages_latest-libre.rtl8814au
linuxPackages_latest-libre.rtl8821au
linuxPackages_latest-libre.rtl88xxau-aircrack
linuxPackages_latest-libre.rtlwifi_new
linuxPackages_latest.anbox
linuxPackages_latest.batman_adv
linuxPackages_latest.chipsec
linuxPackages_latest.exfat-nofuse
linuxPackages_latest.mxu11x0
linuxPackages_latest.ndiswrapper
linuxPackages_latest.netatop
linuxPackages_latest.nvidiabl
linuxPackages_latest.openafs_1_8
linuxPackages_latest.r8168
linuxPackages_latest.rtl8814au
linuxPackages_latest.rtl8821au
linuxPackages_latest.rtl88xxau-aircrack
linuxPackages_latest.rtlwifi_new
linuxPackages_latest_hardened.anbox
linuxPackages_latest_hardened.batman_adv
linuxPackages_latest_hardened.chipsec
linuxPackages_latest_hardened.exfat-nofuse
linuxPackages_latest_hardened.mxu11x0
linuxPackages_latest_hardened.ndiswrapper
linuxPackages_latest_hardened.netatop
linuxPackages_latest_hardened.nvidiabl
linuxPackages_latest_hardened.openafs_1_8
linuxPackages_latest_hardened.r8168
linuxPackages_latest_hardened.rtl8814au
linuxPackages_latest_hardened.rtl8821au
linuxPackages_latest_hardened.rtl88xxau-aircrack
linuxPackages_latest_hardened.rtlwifi_new
linuxPackages_latest_xen_dom0.anbox
linuxPackages_latest_xen_dom0.batman_adv
linuxPackages_latest_xen_dom0.chipsec
linuxPackages_latest_xen_dom0.exfat-nofuse
linuxPackages_latest_xen_dom0.mxu11x0
linuxPackages_latest_xen_dom0.ndiswrapper
linuxPackages_latest_xen_dom0.netatop
linuxPackages_latest_xen_dom0.nvidiabl
linuxPackages_latest_xen_dom0.openafs_1_8
linuxPackages_latest_xen_dom0.r8168
linuxPackages_latest_xen_dom0.rtl8814au
linuxPackages_latest_xen_dom0.rtl8821au
linuxPackages_latest_xen_dom0.rtl88xxau-aircrack
linuxPackages_latest_xen_dom0.rtlwifi_new
linuxPackages_latest_xen_dom0_hardened.anbox
linuxPackages_latest_xen_dom0_hardened.batman_adv
linuxPackages_latest_xen_dom0_hardened.chipsec
linuxPackages_latest_xen_dom0_hardened.exfat-nofuse
linuxPackages_latest_xen_dom0_hardened.mxu11x0
linuxPackages_latest_xen_dom0_hardened.ndiswrapper
linuxPackages_latest_xen_dom0_hardened.netatop
linuxPackages_latest_xen_dom0_hardened.nvidiabl
linuxPackages_latest_xen_dom0_hardened.openafs_1_8
linuxPackages_latest_xen_dom0_hardened.r8168
linuxPackages_latest_xen_dom0_hardened.rtl8814au
linuxPackages_latest_xen_dom0_hardened.rtl8821au
linuxPackages_latest_xen_dom0_hardened.rtl88xxau-aircrack
linuxPackages_latest_xen_dom0_hardened.rtlwifi_new
linuxPackages_testing_bcachefs.ndiswrapper
linuxPackages_testing_bcachefs.rtl8814au
linuxPackages_testing_bcachefs.rtl8821au
linuxPackages_xen_dom0.mxu11x0
linuxPackages_xen_dom0.ndiswrapper
linuxPackages_xen_dom0.r8168
linuxPackages_xen_dom0.rtl8814au
linuxPackages_xen_dom0.rtl8821au
linuxPackages_xen_dom0.rtlwifi_new
linuxPackages_xen_dom0_hardened.mxu11x0
linuxPackages_xen_dom0_hardened.ndiswrapper
linuxPackages_xen_dom0_hardened.openafs_1_8
linuxPackages_xen_dom0_hardened.r8168
linuxPackages_xen_dom0_hardened.rtl8814au
linuxPackages_xen_dom0_hardened.rtl8821au
linuxPackages_xen_dom0_hardened.rtlwifi_new
linuxPackages_zen.anbox
linuxPackages_zen.batman_adv
linuxPackages_zen.chipsec
linuxPackages_zen.exfat-nofuse
linuxPackages_zen.mxu11x0
linuxPackages_zen.ndiswrapper
linuxPackages_zen.netatop
linuxPackages_zen.nvidiabl
linuxPackages_zen.openafs_1_8
linuxPackages_zen.r8168
linuxPackages_zen.rtl8814au
linuxPackages_zen.rtl8821au
linuxPackages_zen.rtl88xxau-aircrack
linuxPackages_zen.rtlwifi_new

@jonringer
Copy link
Contributor

the kernel modules have been appropriately marked broken.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/policy-on-marking-packages-as-broken/9861/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonringer jonringer

Labels
0.kind: bug Something is broken 6.topic: release process Issues or PRs which are parts of the NixOS release process
Projects
None yet
Milestone
20.09
Development

No branches or pull requests
5 participants
@das-g @jonringer @cole-h @worldofpeace @nixos-discourse