From 7da94f70b91b0bdce5fca5ad4d2d10ba2e1bcfd4 Mon Sep 17 00:00:00 2001 From: Ryan Mulligan Date: Sat, 17 Oct 2020 07:44:40 -0700 Subject: [PATCH] doc: update unstable version naming conventions The previous explanation did not make it clear where the word "unstable" should go when name is split into pname and version. By putting it at the end, we can get builtins.parseDrvName to parse things nicely: > builtins.parseDrvName "pname-2020-10-17-unstable" { name = "pname"; version = "2020-10-17-unstable"; } It is not good to put it in the pname, because then the pname will not match with the attrpath. --- doc/contributing/coding-conventions.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/coding-conventions.xml b/doc/contributing/coding-conventions.xml index fcb6501f61599..7f828dcb44510 100644 --- a/doc/contributing/coding-conventions.xml +++ b/doc/contributing/coding-conventions.xml @@ -229,7 +229,7 @@ args.stdenv.mkDerivation (args // { - If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23". + If a package is not a release but a commit from a repository, then the version part of the name must be the commit date of that (fetched) commit in "YYYY-MM-DD" format, followed by "-unstable". For example, "pkgname-2014-09-23-unstable".