From cca0b749542d255056b4c13029a4855e455af862 Mon Sep 17 00:00:00 2001
From: adisbladis <adisbladis@gmail.com>
Date: Fri, 27 Mar 2020 13:26:16 +0000
Subject: [PATCH] Fix Mypy type errors in util.py

---
 nixops/util.py | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/nixops/util.py b/nixops/util.py
index 4f467ace1..b98cbe0c0 100644
--- a/nixops/util.py
+++ b/nixops/util.py
@@ -92,6 +92,7 @@ def logged_exec(
     else:
         passed_stdin = devnull
 
+    fds: List[IO[str]] = []
     if capture_stdout:
         process = subprocess.Popen(
             command,
@@ -102,8 +103,8 @@ def logged_exec(
             preexec_fn=preexec_fn,
             text=True,
         )
-        fds = [process.stdout, process.stderr]
-        log_fd = process.stderr
+        fds = [fd for fd in [process.stdout, process.stderr] if fd]
+        log_fd_opt = process.stderr
     else:
         process = subprocess.Popen(
             command,
@@ -114,8 +115,21 @@ def logged_exec(
             preexec_fn=preexec_fn,
             text=True,
         )
-        fds = [process.stdout]
-        log_fd = process.stdout
+        if process.stdout:
+            fds = [process.stdout]
+        log_fd_opt = process.stdout
+
+    if process.stdin is None:
+        raise ValueError("process.stdin was None")
+    process_stdin: IO[str] = process.stdin
+
+    if process.stdout is None:
+        raise ValueError("process.stdout was None")
+    process_stdout: IO[str] = process.stdout
+
+    if log_fd_opt is None:
+        raise ValueError("log_fd was None")
+    log_fd: IO[str] = log_fd_opt
 
     # FIXME: this can deadlock if stdin_string doesn't fit in the
     # kernel pipe buffer.