Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CanonPath, SourcePath: Change operator + to / #9939

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Feb 5, 2024

Motivation

This is less confusing and makes it more similar to std::filesystem::path.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This is less confusing and makes it more similar to std::filesystem::path.
@github-actions github-actions bot added new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store fetching Networking with the outside (non-Nix) world, input locking labels Feb 5, 2024
@Ericson2314
Copy link
Member

std::filesystem::path also works this way, so if we use that more this will keep things consistent.

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I thought of this at some point

The issue is mainly about doing this in the expression language though, but this is great!

@roberth roberth enabled auto-merge February 5, 2024 14:37
@roberth roberth merged commit a31f2cb into NixOS:master Feb 5, 2024
7 checks passed
@edolstra edolstra deleted the slash-operator branch December 9, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetching Networking with the outside (non-Nix) world, input locking new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants