installer: update macOS version check to 10.12.2 #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nixpkgs will drop support for <10.12 soon and thus a nix release built using the 19.03 channel will also require a newer version of macOS.
|
So we ended up reverting that PR. I think we should probably hold off on this bump until the 19.03 release. There were a lot more failures than originally expected & this will give people a few more months to upgrade their machines. |
| echo "$0: macOS $(sw_vers -productVersion) is not supported, upgrade to 10.10 or higher" | ||
| macos_major=$(sw_vers -productVersion | cut -d '.' -f 2) | ||
| macos_minor=$(sw_vers -productVersion | cut -d '.' -f 3) | ||
| if [ "$macos_major" -lt 12 ] || ([ "$macos_major" -eq 12 ] && [ "$macos_minor" -lt 6 ]); then |
There was a problem hiding this comment.
@LnL7 Do we care about the minor version? I would think these would be compatible, although I haven't tested it.
There was a problem hiding this comment.
I don't know what version exactly, but the previous attempt definitively needed >10.12.2.
matthewbauer
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nixpkgs will drop support for <10.12 soon and thus a nix release built
using the 19.03 channel will also require a newer version of macOS.
See NixOS/nixpkgs#47678