Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

during next sync, keep an eye on upgrade-nix-store-path-url change #14

Open
abathur opened this issue Apr 24, 2024 · 2 comments
Open

during next sync, keep an eye on upgrade-nix-store-path-url change #14

abathur opened this issue Apr 24, 2024 · 2 comments

Comments

@abathur
Copy link
Member

abathur commented Apr 24, 2024

Upstream adopted a new nix setting that enables them to declare/host their own source for the ~stable version of Nix. This was added in:

DeterminateSystems#772

We'll either need to revert this or check in with the Nix team to clarify what behavior they want here (and if they, too, would like to set a source outside of nixpkgs for this).

@abathur abathur changed the title during future syncs, keep an eye on upgrade-nix-store-path-url change during next sync, keep an eye on upgrade-nix-store-path-url change Apr 24, 2024
@abathur abathur added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested and removed documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested labels Apr 27, 2024
@abathur
Copy link
Member Author

abathur commented Apr 27, 2024

... butt-labeled 🙃

@abathur
Copy link
Member Author

abathur commented May 26, 2024

This will be added by the current sync PR to src/action/common/place_nix_configuration.rs:

I'm inclined not to pick this nit in the context of that PR since we probably need at least one more changeset to round up and replace most references to the determinate.systems domain.

Edit: the diff didn't make this clear, but it's added within our #[cfg(not(feature = "nix-community"))] block, so I think this only needs action if the Nix team wants to use its own source for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant