Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WrappingParameterizedRunner debug code causes failure on Windows #12

Open
Nava2 opened this issue Mar 24, 2017 · 5 comments
Open

WrappingParameterizedRunner debug code causes failure on Windows #12

Nava2 opened this issue Mar 24, 2017 · 5 comments
Labels

Comments

@Nava2
Copy link

Nava2 commented Mar 24, 2017

This debug code:

// WrappingParameterizedRunner.java L313
/* ** DEBUG export class to /tmp/x.class ** */
		try {
			FileOutputStream fos = new FileOutputStream("/tmp/x.class");
			fos.write(clazzBytes);
			fos.close();
		} catch (Exception e1) {
			e1.printStackTrace();
		}
		/* ** /DEBUG ** */

throws on Windows immediately, /tmp doesn't exist. Could be replaced with the Files.createTempFile() or similar.

@xkr47
Copy link
Member

xkr47 commented Mar 27, 2017

*blush* It should just be removed. It was used during development.

@xkr47
Copy link
Member

xkr47 commented Mar 27, 2017

Actually it was fixed a year ago but no new release has been made. Maybe time for one then!

@Nava2
Copy link
Author

Nava2 commented Mar 27, 2017

I had a feeling.. Once JUnit 5 stabilizes their parameterized testing, hopefully it means this library isn't needed anymore and no more maintenance. 🙌

@xkr47 xkr47 added the bug label Mar 29, 2017
@IRasmivan
Copy link

Any Plan to fix this!?

@xanyook
Copy link

xanyook commented Jun 11, 2018

hello,

any chance for a release on this correction (fe4d2d9) (thx xkr47) ?
this lib looks nice but can't run it on local due to this issue.

Had to fix it myself bu overriding WrappingParameterizedRunner but need to add ParameterizedSuiteBuilder, DescriptionMappingRunNotifierProxy, ClassLoaderInjector sources too, it s not clean in my project :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants