You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We want to add a new error along the lines of this
/** * Call to trigger sms or call challenge for OneLogin is not implemented. */TRIGGER_CHALLENGE_NOT_IMPLEMENTED(99244, "Call to trigger sms or call challenge for OneLogin is not implemented.", SC_NOT_IMPLEMENTED),
@fieldju thanks for the report. We can look at adding some more status codes to the list and trying to find reasonable spots for where they should go in the priority order. We may even decide this kind of situation isn't something that should fail-fast - maybe we should just silently put any unspecified status codes as having lowest priority order?
In the meantime, you can easily work around this by overriding the getStatusCodePriorityOrder() method in your DefaultApiErrorsImpl. It would look something like this:
@OverridepublicList<Integer> getStatusCodePriorityOrder() {
// Make a copy of the DEFAULT_STATUS_CODE_PRIORITY_ORDER list.List<Integer> statusCodePriorityOrder = newArrayList<>(DEFAULT_STATUS_CODE_PRIORITY_ORDER);
// TODO: Put 501 wherever it should go based on what priority you want it to have. For now we'll put it at the end.statusCodePriorityOrder.add(501);
returnstatusCodePriorityOrder;
}
Please read the javadocs for ProjectApiErrors.getStatusCodePriorityOrder() - they'll explain the "what's" and "why's".
This list here https://github.com/Nike-Inc/backstopper/blob/master/backstopper-core/src/main/java/com/nike/backstopper/apierror/projectspecificinfo/ProjectApiErrors.java#L233 doesn't have 501 NOT_IMPLEMENTED in the list.
This stops us from created new new error here: https://github.com/Nike-Inc/cerberus-management-service/blob/master/src/main/java/com/nike/cerberus/error/DefaultApiError.java#L310
We want to add a new error along the lines of this
The text was updated successfully, but these errors were encountered: