Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot Signatures Missing Substitution Text #11

Open
DarioS opened this issue Mar 26, 2020 · 4 comments
Open

Plot Signatures Missing Substitution Text #11

DarioS opened this issue Mar 26, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@DarioS
Copy link

DarioS commented Mar 26, 2020

If the plot has large height, the DNA substitution disappears which is plotted when it has small height.

plotSignatures

@andreadega andreadega added the bug Something isn't working label Mar 26, 2020
@andreadega
Copy link
Member

The dimensions of the notations are tailored to the dimensions that we use in the jpg plotting. When plotting like this to console some deformation is possible, and we could probably improve the code to adjust it. However, this is not a priority for us, so I don't know whether we will fix this. This package is mainly to deliver core methods, while one can use other software for better visualisation.

@andreadega
Copy link
Member

As of v2.1.2 this issue is likely to remain unresolved. We have optimised plotting for a specific aspect ratio and pdf format, while the issue here would require rewriting for an arbitrary aspect ratio of the plot.

@gevro
Copy link

gevro commented Apr 29, 2022

I noticed this too. What is the dimensions and/or dimension ratio you recommend for plotting?

@andreadega
Copy link
Member

We recommend to plot to pdf, for example:

plotSignatures(signature_data_matrix = yourMatrix,
               output_file = yourFile.pdf)

This will generate plots according to our predifined aspect ratio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants