Finish pyOpenSci review #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Be able to parse both "normal" and short format TextGrid files, in both UTF-8 and UTF-16 encoding * Remove empty intervals by default, provide option to not remove them * Be able to load a TextGrid with multiple IntervalTiers and then convert to an Annotation with multiple sequences * Use reprlib with the vendored TextGrid so it is readable Squash commits: - Remove _vendor/textgrid - Move textgrid module into sub-package - Move test_textgrid into its own subpackage - Change example TextGrid to a file with more than one tier, for demo purposes - Add textgrid sub-package in formats/seq/ - Add tests/data_for_tests/textgrid/ - Add test fixtures: - a_parse_textgrid_path to fixtures/textgrid.py - add textgrid with empty interval fixtures - Add test_textgrid sub-package in test_formats/test_seq - Rewrite doc/formats/seq/textgrid.md
NickleDave
force-pushed
the
finish-pyos-review
branch
from
7080693 to
9bc051f
Compare
24 tasks
NickleDave
added a commit
that referenced
this pull request
Mar 29, 2023
|
@all-contributors please add @YannickJadoul for ideas bug docs userTesting |
|
I've put up a pull request to add @YannickJadoul! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42 and #241