Make fixes for Windows / CI #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NickleDave
commented
Mar 20, 2023
NickleDave
commented
- Fixes the Nox session 'dev' so it works on Windows
- Fix how we convert numpy integers to Python native integers for Segment instances, so that it doesn't fail on Windows, where the default numpy integer dtype is int32 not int64
The onset/offset sample attributes of Segment have a converter that was written to convert numpy int64 to Python int. But it turns out that we don't always default to int64, e.g., on Windows it's int32. The converter failed then since it first checked for a dtype attribute, then checked *only* for int64. This logical error caused us to return None for int32. Instead we check whether there's a dtype *and* it's an instance of np.integer, which catches any numpy int type.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 94.10% 93.85% -0.25%
==========================================
Files 41 41
Lines 1510 1514 +4
==========================================
Hits 1421 1421
- Misses 89 93 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.