Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors and add linting to CI #54

Open
Unique-Divine opened this issue Oct 9, 2024 · 0 comments
Open

Fix linter errors and add linting to CI #54

Unique-Divine opened this issue Oct 9, 2024 · 0 comments
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5

Comments

@Unique-Divine
Copy link
Member

Unique-Divine commented Oct 9, 2024

Current linter errors when running

golangci-lint run --allow-parallel-runners --fix
feeder/eventstream/stream.go:27:22: SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
	transportDialOpt := grpc.WithInsecure()
	                    ^
feeder/eventstream/stream_test.go:60:39: SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
	conn, err := grpc.Dial(grpcEndpoint, grpc.WithInsecure())
	                                     ^
feeder/priceposter/client.go:58:22: SA1019: grpc.WithInsecure is deprecated: use WithTransportCredentials and insecure.NewCredentials() instead. Will be supported throughout 1.x. (staticcheck)
	transportDialOpt := grpc.WithInsecure()
	                    ^
cmd/root.go:72:22: Error return value of `http.ListenAndServe` is not checked (errcheck)
		http.ListenAndServe(":8080", nil)
		                   ^
exit status 1

Commit

6f1804f

@Unique-Divine Unique-Divine added the S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5
Projects
Status: ⚡ Building 🧱
Development

No branches or pull requests

1 participant