fix(contact): change instagram URL into ID (#39) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delphox60
requested review from
mcauto,
KimHunJin and
CODe5753
as code owners
|
스크린샷은 as-is to-be가 함께 첨부되면 히스토리 확인하기 더 좋을 것 같아요~ 아 이슈 페이지를 통해 to-be는 확인했습니다 to-be와 as-is를 구분하여 한 이슈 또는 mr 안에 첨부해주세요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
소스코드 내 하드코딩된 값을 수정하여, 타 채널처럼 인스타그램 링크가 ID로 간소화되어 표시되도록 수정했습니다.
CONTACT항목들의 업데이트가 잦지는 않겠지만, 현재처럼 소스코드에 하드코딩한 값을 수정하는 방식을 개선할 필요가 있어 보입니다. (#38)Issue
#39
스크린샷