From 95e9390681c30f524c589848d8826248961d9860 Mon Sep 17 00:00:00 2001
From: Alexandre Walsh <awalsh@nexapp.ca>
Date: Mon, 22 Jul 2019 23:01:10 -0400
Subject: [PATCH 1/2] Removed slf4j-nop dependency

---
 README.md |   2 +-
 pom.xml   | 230 ++++++++++++++++++++++++++----------------------------
 2 files changed, 113 insertions(+), 119 deletions(-)

diff --git a/README.md b/README.md
index a8b5541..3f83217 100644
--- a/README.md
+++ b/README.md
@@ -149,7 +149,7 @@ Then, you simply add the dependency as follows:
 <dependency>
 	<groupId>ca.nexapp</groupId>
 	<artifactId>core</artifactId>
-	<version>0.1.0</version>
+	<version>0.1.1</version>
 </dependency>
 ```
 
diff --git a/pom.xml b/pom.xml
index d5a854a..2889c58 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1,136 +1,130 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-	<modelVersion>4.0.0</modelVersion>
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
 
-	<groupId>ca.nexapp</groupId>
-	<artifactId>core</artifactId>
-	<version>0.1.0</version>
-	<packaging>jar</packaging>
+    <groupId>ca.nexapp</groupId>
+    <artifactId>core</artifactId>
+    <version>0.1.1</version>
+    <packaging>jar</packaging>
 
-	<name>Nexapp Core</name>
+    <name>Nexapp Core</name>
 
-	<properties>
-		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-		<java.version>1.8</java.version>
-		<github.global.server>github</github.global.server>
-	</properties>
+    <properties>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <java.version>1.8</java.version>
+        <github.global.server>github</github.global.server>
+    </properties>
 
-	<build>
-		<plugins>
-			<plugin>
-				<groupId>org.apache.maven.plugins</groupId>
-				<artifactId>maven-compiler-plugin</artifactId>
-				<version>3.2</version>
-				<configuration>
-					<source>${java.version}</source>
-					<target>${java.version}</target>
-				</configuration>
-			</plugin>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <version>3.2</version>
+                <configuration>
+                    <source>${java.version}</source>
+                    <target>${java.version}</target>
+                </configuration>
+            </plugin>
 
-			<plugin>
-				<artifactId>maven-deploy-plugin</artifactId>
-				<version>2.8.1</version>
-				<configuration>
-					<altDeploymentRepository>internal.repo::default::file://${project.build.directory}/mvn-repo</altDeploymentRepository>
-				</configuration>
-			</plugin>
+            <plugin>
+                <artifactId>maven-deploy-plugin</artifactId>
+                <version>2.8.1</version>
+                <configuration>
+                    <altDeploymentRepository>internal.repo::default::file://${project.build.directory}/mvn-repo</altDeploymentRepository>
+                </configuration>
+            </plugin>
 
-			<plugin>
-				<groupId>com.github.github</groupId>
-				<artifactId>site-maven-plugin</artifactId>
-				<version>0.12</version>
-				<configuration>
-					<message>Maven artifacts for ${project.version}</message>
-					<noJekyll>true</noJekyll>
-					<outputDirectory>${project.build.directory}/mvn-repo</outputDirectory>
-					<branch>refs/heads/mvn-repo</branch>
-					<includes>
-						<include>**/*</include>
-					</includes>
-					<merge>true</merge>
-					<repositoryName>NexappCore</repositoryName>
-					<repositoryOwner>Nexapp</repositoryOwner>
-				</configuration>
-				<executions>
-					<!-- run site-maven-plugin's 'site' target as part of the build's normal 'deploy' phase -->
-					<execution>
-						<goals>
-							<goal>site</goal>
-						</goals>
-						<phase>deploy</phase>
-					</execution>
-				</executions>
-			</plugin>
-		</plugins>
-	</build>
+            <plugin>
+                <groupId>com.github.github</groupId>
+                <artifactId>site-maven-plugin</artifactId>
+                <version>0.12</version>
+                <configuration>
+                    <message>Maven artifacts for ${project.version}</message>
+                    <noJekyll>true</noJekyll>
+                    <outputDirectory>${project.build.directory}/mvn-repo</outputDirectory>
+                    <branch>refs/heads/mvn-repo</branch>
+                    <includes>
+                        <include>**/*</include>
+                    </includes>
+                    <merge>true</merge>
+                    <repositoryName>NexappCore</repositoryName>
+                    <repositoryOwner>Nexapp</repositoryOwner>
+                </configuration>
+                <executions>
+                    <!-- run site-maven-plugin's 'site' target as part of the build's normal 'deploy' phase -->
+                    <execution>
+                        <goals>
+                            <goal>site</goal>
+                        </goals>
+                        <phase>deploy</phase>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
 
-	<distributionManagement>
-		<repository>
-			<id>internal.repo</id>
-			<name>Temporary Staging Repository</name>
-			<url>file://${project.build.directory}/mvn-repo</url>
-		</repository>
-	</distributionManagement>
+    <distributionManagement>
+        <repository>
+            <id>internal.repo</id>
+            <name>Temporary Staging Repository</name>
+            <url>file://${project.build.directory}/mvn-repo</url>
+        </repository>
+    </distributionManagement>
 
-	<repositories>
-		<repository>
-			<id>nexapp-math-mvn-repo</id>
-			<url>https://raw.github.com/nexapp/nexappmath/mvn-repo/</url>
-		</repository>
-	</repositories>
+    <repositories>
+        <repository>
+            <id>nexapp-math-mvn-repo</id>
+            <url>https://raw.github.com/nexapp/nexappmath/mvn-repo/</url>
+        </repository>
+    </repositories>
 
-	<dependencies>
-		<dependency>
-			<groupId>junit</groupId>
-			<artifactId>junit</artifactId>
-			<version>4.12</version>
-			<scope>test</scope>
-		</dependency>
+    <dependencies>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>4.12</version>
+            <scope>test</scope>
+        </dependency>
 
-		<dependency>
-			<groupId>com.pholser</groupId>
-			<artifactId>junit-quickcheck-core</artifactId>
-			<version>0.7</version>
-			<scope>test</scope>
-		</dependency>
+        <dependency>
+            <groupId>com.pholser</groupId>
+            <artifactId>junit-quickcheck-core</artifactId>
+            <version>0.7</version>
+            <scope>test</scope>
+        </dependency>
 
-		<dependency>
-			<groupId>org.mockito</groupId>
-			<artifactId>mockito-all</artifactId>
-			<version>1.10.19</version>
-			<scope>test</scope>
-		</dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-all</artifactId>
+            <version>1.10.19</version>
+            <scope>test</scope>
+        </dependency>
 
-		<dependency>
-			<groupId>com.google.truth</groupId>
-			<artifactId>truth</artifactId>
-			<version>0.39</version>
-			<scope>test</scope>
-		</dependency>
+        <dependency>
+            <groupId>com.google.truth</groupId>
+            <artifactId>truth</artifactId>
+            <version>0.39</version>
+            <scope>test</scope>
+        </dependency>
 
-		<dependency>
-			<groupId>ca.nexapp</groupId>
-			<artifactId>math</artifactId>
-			<version>0.0.7</version>
-		</dependency>
+        <dependency>
+            <groupId>ca.nexapp</groupId>
+            <artifactId>math</artifactId>
+            <version>0.0.7</version>
+        </dependency>
 
-		<dependency>
-			<groupId>com.google.maps</groupId>
-			<artifactId>google-maps-services</artifactId>
-			<version>0.2.7</version>
-		</dependency>
-		
-		<dependency>
-			<groupId>org.slf4j</groupId>
-			<artifactId>slf4j-nop</artifactId>
-			<version>1.7.25</version>
-		</dependency>
+        <dependency>
+            <groupId>com.google.maps</groupId>
+            <artifactId>google-maps-services</artifactId>
+            <version>0.2.7</version>
+        </dependency>
 
-		<dependency>
-			<groupId>commons-codec</groupId>
-			<artifactId>commons-codec</artifactId>
-			<version>1.11</version>
-		</dependency>
-	</dependencies>
+        <dependency>
+            <groupId>commons-codec</groupId>
+            <artifactId>commons-codec</artifactId>
+            <version>1.11</version>
+        </dependency>
+    </dependencies>
 </project>
\ No newline at end of file

From ba1302bc464f638840736a627799563197757225 Mon Sep 17 00:00:00 2001
From: Alexandre Walsh <awalsh@nexapp.ca>
Date: Mon, 22 Jul 2019 23:05:40 -0400
Subject: [PATCH 2/2] Fixed test

---
 .../ca/nexapp/core/geocoding/GoogleGeocoderAPIITest.java     | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/test/java/ca/nexapp/core/geocoding/GoogleGeocoderAPIITest.java b/src/test/java/ca/nexapp/core/geocoding/GoogleGeocoderAPIITest.java
index 99005ca..1aa0d8a 100644
--- a/src/test/java/ca/nexapp/core/geocoding/GoogleGeocoderAPIITest.java
+++ b/src/test/java/ca/nexapp/core/geocoding/GoogleGeocoderAPIITest.java
@@ -30,7 +30,7 @@ public void canFindAPublicPlace() {
 
     @Test
     public void canFindAPostalCode() {
-        String stGeorgesPostalCode = "G5Y";
+        String stGeorgesPostalCode = "G5Y 0A8";
 
         Optional<Coordinates> location = geocoder.lookup(stGeorgesPostalCode);
 
@@ -39,7 +39,7 @@ public void canFindAPostalCode() {
 
     @Test
     public void cannotFindAnInvalidAddress() {
-        String unexistingAddress = "as-qw-bc-zob-120200";
+        String unexistingAddress = "blpasdadqwdqkdjnak";
 
         Optional<Coordinates> location = geocoder.lookup(unexistingAddress);
 
@@ -56,5 +56,4 @@ private void assertThatLocationIsNearOf(Optional<Coordinates> location, double e
         assertThat(latitude).isWithin(threshold).of(expectedLatitude);
         assertThat(longitude).isWithin(threshold).of(expectedLongitude);
     }
-
 }