Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths broken in declaration files #29

Closed
davidgruar opened this issue Sep 12, 2018 · 1 comment · Fixed by #30
Closed

Relative paths broken in declaration files #29

davidgruar opened this issue Sep 12, 2018 · 1 comment · Fixed by #30

Comments

@davidgruar
Copy link
Contributor

In the latest release (1.1.1) some relative paths in declaration files are incorrectly specified - this appears to be due to microsoft/TypeScript#24599. This results in build errors in any project that consumes not-valid.

Example, in bin/create-validator.d.ts:

export declare const createValidator: <T>(predicate: ValidationPredicate<T>, message: string) => (value: T) => import("../../../Code/validation/src/results/validation-result").ValidationResult;
export declare const createValidatorFactory: <T>(predicate: (value: T) => boolean, defaultMessage: string) => (message?: string | undefined) => (value: T) => import("../../../Code/validation/src/results/validation-result").ValidationResult;
export declare const createAsyncValidator: <T>(predicate: (value: T) => Promise<boolean>, message: string) => (value: T) => Promise<import("../../../Code/validation/src/results/validation-result").ValidationResult>;
export declare const createAsyncValidatorFactory: <T>(predicate: (value: T) => Promise<boolean>, defaultMessage: string) => (message?: string | undefined) => (value: T) => Promise<import("../../../Code/validation/src/results/validation-result").ValidationResult>;

Upgrading to typescript@3 fixes this.

@davidgruar
Copy link
Contributor Author

@Jameskmonger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant