You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
__init__ states that users should use the from_* factory methods instead. Who is responsible for closing objects that are being opened there? E.g., in from_zarr_store the factory methods opens the zarr store, but other than the returned LindiH5pyFile object, no-one else has access/owns the file.
For factory methods that require an already opened file to be handed in, I agree, that LINIDI should not just close it. But for cases where LINDI functions open the file (and in particular when the opened file/store is not being exposed to the caller), I think it should be the role of LINDI to close.
__init__
states that users should use thefrom_*
factory methods instead. Who is responsible for closing objects that are being opened there? E.g., infrom_zarr_store
the factory methods opens the zarr store, but other than the returnedLindiH5pyFile
object, no-one else has access/owns the file.lindi/lindi/LindiH5pyFile/LindiH5pyFile.py
Lines 52 to 59 in fe51dbc
For factory methods that require an already opened file to be handed in, I agree, that LINIDI should not just close it. But for cases where LINDI functions open the file (and in particular when the opened file/store is not being exposed to the caller), I think it should be the role of LINDI to close.
Originally posted by @oruebel in #21 (comment)
The text was updated successfully, but these errors were encountered: