-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect interval in annotations #607
Fix incorrect interval in annotations #607
Conversation
Datasets affected since version 1.0:
|
We need to create more tests for this situation, but for a new PR! |
A bit more context: In 1.0.0, for all the datasets where The durations in the annotations were correct. This did not affect the creation of epochs when using MOABB’s paradigms. |
Ok, that why there was no regression in MOABB but it was the case for Braindecode. Good catch. |
The annotations added by
SetRawAnnotations
do not take into account the case when a dataset’s interval does not start at 0. This PR fixes it.