Normalize dataset names #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I renamed 18 datasets and 6 compound datasets. All the old class names are still available but are marked as depreciated. The old class names are not in |
Fixing the number of subjects in BI2014b.
…lity with depreciated names)
Update dataset summaries
|
Ready to merge it you're happy with it @bruAristimunha |
sylvchev
reviewed
Aug 16, 2023
sylvchev
approved these changes
Aug 17, 2023
| @@ -54,3 +54,24 @@ | |||
| # Call this last in order to make sure the dataset list contains all | |||
| # the datasets imported in this file. | |||
| _init_dataset_list() | |||
There was a problem hiding this comment.
This will break all the braindecode examples, @PierreGtch and @sylvchev. Can I put the _init_dataset_list() in the end of the file?
There was a problem hiding this comment.
no problem on my side!
We just have to remove the test that ensures that the dataset codes are unique in the list.
Maybe we could also put the compound datasets in the same list instead of having a separate compound_datasets_list
There was a problem hiding this comment.
Nice! I will handle with compound datasets in another PR.
bruAristimunha
added a commit
to bruAristimunha/moabb
that referenced
this pull request
Aug 19, 2023
* Add depreciation decorator * Update test_dataset_list * Ignore aliases in test_dataset_list * Add is_abreviation function * Add tests for is_abreviation and is-camel-kebab_case * Rename is_abbrev * Fix dashes in is_abbrev * Fix error message * Update BNCI datasets names and codes * Update mamem dataset codes * Update epfl dataset code * Update DeamonsP300 dataset code * Test if codes are unique * Update Huebner codes * Relax is_abrev * Update FakeDataset code * Update code and name of Passive Head Mounted Display with Music Listening dataset * Update name of GrosseWentrup2009 * Update code of Nakanishi2015 * Update name of SSVEPExo * Update add argument suffix to Shin2017 and rename to BaseShin2017 * Update code of Sosulski2019 * Re-rename HeadMountedDisplay because colision with VR-P300 * Rename VirtualReality to Cattan2019_VR * Add alias for VirtualReality * Update code of Wand2016 * Update name of braininvaders datasets * Add compound_dataset_list with test * Del _init_dataset_list after usage * Change names of bi-illeteracy datasets * Fix hardcoded code test for Cattan2019-VR * Fix benchmark test * Update whats_new.rst * Update BI2014b Fixing the number of subjects in BI2014b. * Update dataset summaries * Fix case when note already present * Fix forgotten change of BNCI2014001 * warn instead of raise when code and class name don't match (compatibility with depreciated names) * Add test for depreciated datasets init * Fix asserNoLogs only introduced in python3.10 * Specity test for depreciated warning * Undo edit to old whats_new.rst lines * Fix note formatting * Update SSVEPExo name and code to Kalunga2016 --------- Co-authored-by: Bru <[email protected]> Co-authored-by: Sara Sedlar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moabb.utils.depreciated_aliasdecorator