Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jNeuroML -neuron continues even if .mod files fail to compile #54

Open
JustasB opened this issue Oct 31, 2017 · 2 comments
Open

jNeuroML -neuron continues even if .mod files fail to compile #54

JustasB opened this issue Oct 31, 2017 · 2 comments

Comments

@JustasB
Copy link

JustasB commented Oct 31, 2017

Using the following command on the attached LEMS & channel files (in LEMS.zip)

jnml LEMS_3point2Eminus4mM_Deactivation_Golgi_KCa_CML.nml -neuron -nogui -run

Fails to compile resulting mod files (as expected) and includes the following messaging in the output:

NOTE: make sure you can compile NEURON mod files on your system!
and later:
(INFO) Success: false

However, jnml unexpectedly continues running NEURON despite failure to compile the mod files:

(INFO) Have successfully executed command: /home/justas/neuron/nrn/x86_64/bin/nrniv -python /home/justas/neuroml-db/www/NeuroMLmodels/NMLCH000021/LEMS_3point2Eminus4mM_Deactivation_Golgi_KCa_CML.nml_nrn.py
(INFO) NRN Error  >>> NEURON -- Release 7.4 (1370:16a7055d4a86) 2015-11-09
(INFO) NRN Error  >>> Duke, Yale, and the BlueBrain Project -- Copyright 1984-2015
(INFO) NRN Error  >>> See http://www.neuron.yale.edu/neuron/credits

In some cases, this could result in simulations with silent failures -- e.g. the simulation proceeds, even though the .mod files failed to compile, resulting in erroneous simulation output.

If in cases of (INFO) Success: false, jnml stopped further execution, such failures would be prevented.

@rgerkin
Copy link

rgerkin commented Nov 10, 2017

+1

pgleeson added a commit to NeuroML/org.neuroml.export that referenced this issue Nov 16, 2017
Added support for dimension per_voltage2 in Neuron
pgleeson added a commit that referenced this issue Nov 16, 2017
pgleeson added a commit to NeuroML/pyNeuroML that referenced this issue Nov 16, 2017
@pgleeson
Copy link
Member

Working in development branches. Need to test more & make a release...

@github-project-automation github-project-automation bot moved this to 🆕 New in NeuroML backlog Oct 2, 2023
@sanjayankur31 sanjayankur31 moved this from 🆕 New to 🔖 Ready in NeuroML backlog Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants