Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMoveOnsetAndPeak is not agnostic to bin_size #10

Open
raeedcho opened this issue Jun 23, 2020 · 0 comments
Open

getMoveOnsetAndPeak is not agnostic to bin_size #10

raeedcho opened this issue Jun 23, 2020 · 0 comments

Comments

@raeedcho
Copy link
Collaborator

Because it uses a differences in speed from bin to bin to find a movement onset, it's not agnostic to the bin size. For example, with smaller bins, ds should be smaller because of the smaller timestep, but min_ds doesn't reflect this reliance on timestep.

I think the fix is simply to replace the calls to diff with calls to gradient, but I'm not sure how that would change the rest of the code right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant