Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repeater): implement WS request runner #91

Merged
merged 13 commits into from
Dec 8, 2022

Conversation

derevnjuk
Copy link
Member

closes #89

@derevnjuk derevnjuk added the Type: enhancement New feature or request. label Dec 8, 2022
@derevnjuk derevnjuk self-assigned this Dec 8, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 8, 2022

Code Climate has analyzed commit 1cf82df and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 82.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.8%.

View more on Code Climate.

ostridm
ostridm previously approved these changes Dec 8, 2022
Copy link
Contributor

@ostridm ostridm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

stream.Seek(0, SeekOrigin.Begin); redundant for MemoryStream

@derevnjuk derevnjuk merged commit 224d154 into master Dec 8, 2022
@derevnjuk derevnjuk deleted the feat_#89/implement_WS_request_runner branch December 8, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement WS request runner
2 participants