feat(scan): provide a default scan factory #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 504062c and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 99.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.1% (0.2% change). View more on Code Climate. |
ostridm
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
5 times, most recently
from
6c21728
to
1fc57ec
Compare
ostridm
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
1fc57ec
to
7ebc870
Compare
derevnjuk
requested changes
Dec 2, 2022
ostridm
added a commit
that referenced
this pull request
Dec 5, 2022
adjust according to code review #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) closes #68
ostridm
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
7ebc870
to
155fba6
Compare
ostridm
added a commit
that referenced
this pull request
Dec 5, 2022
adjust according to code review #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) closes #68
ostridm
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
155fba6
to
a273064
Compare
ostridm
added a commit
that referenced
this pull request
Dec 5, 2022
adjust according to code review #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) closes #68
ostridm
added a commit
that referenced
this pull request
Dec 5, 2022
adjust according to code review #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) closes #68
ostridm
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
1f0d337
to
fc3bce7
Compare
derevnjuk
requested changes
Dec 6, 2022
ostridm
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
fc3bce7
to
a451e98
Compare
derevnjuk
requested changes
Dec 6, 2022
ostridm
added a commit
that referenced
this pull request
Dec 7, 2022
adjust according to code review #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) closes #68
update README.md, adjust according to code review closes #68
adjust according to code review #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) #76 (comment) closes #68
ostridm
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
cc1ba55
to
70fee25
Compare
derevnjuk
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
0d5d563
to
bb1cc16
Compare
derevnjuk
force-pushed
the
feat_#68/provide-a-default-scan-factory
branch
from
bb1cc16
to
504062c
Compare
derevnjuk
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #68