-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude empty proofs; 0x0 for 0 instead of 0x #7766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flcl42
force-pushed
the
exclude-empty-proofs-and-no-zeros
branch
from
November 20, 2024 09:04
40610a0
to
5859ca3
Compare
src/Nethermind/Nethermind.Core/JsonConverters/NullableByteReadOnlyMemoryConverter.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Nov 20, 2024
Co-authored-by: Lukasz Rozmej <[email protected]>
flcl42
force-pushed
the
exclude-empty-proofs-and-no-zeros
branch
from
November 20, 2024 12:23
7b62a6f
to
bafe7b1
Compare
flcl42
requested review from
MarekM25,
Marchhill,
smartprogrammer93 and
marcindsobczak
November 20, 2024 12:55
smartprogrammer93
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7759
Remove the difference in responses of proof API
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?