Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude empty proofs; 0x0 for 0 instead of 0x #7766

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Nov 19, 2024

Resolves #7759

Remove the difference in responses of proof API

Changes

  • Exclude empty proofs for not found from results
  • No leading zeros for proof value
  • 0 means 0x0 instead of 0x (null/empty array)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7759 @flcl42 qq: does it fix this issue or it is something different?

@flcl42
Copy link
Contributor Author

flcl42 commented Nov 20, 2024

#7759 @flcl42 qq: does it fix this issue or it is something different?

Yep, seems like that. We are getting empty storage proof values and want not to return em anymore

@flcl42 flcl42 marked this pull request as ready for review November 20, 2024 08:30
@flcl42 flcl42 force-pushed the exclude-empty-proofs-and-no-zeros branch from 40610a0 to 5859ca3 Compare November 20, 2024 09:04
@flcl42 flcl42 changed the base branch from surge-api-tracing-sync to master November 20, 2024 09:04
@flcl42 flcl42 merged commit 55ee32c into master Nov 20, 2024
77 checks passed
@flcl42 flcl42 deleted the exclude-empty-proofs-and-no-zeros branch November 20, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nethermind includes extraneous 0x values in eth_getProof responses, breaking cryptographic consistency.
4 participants