Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override vote in clique proposal #7749

Merged

Conversation

anhnhgutech
Copy link
Contributor

Currently, when we want to update a vote in a proposal, we need to:

  1. Discard the old vote
  2. Add the new vote
Screen.Recording.2024-11-12.at.07.44.06.mov

-> Allow override vote when calling clique proposal

Changes

  • Allow override vote when calling clique proposal

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Screenshots

Screen.Recording.2024-11-12.at.07.42.32.mov

@anhnhgutech anhnhgutech marked this pull request as ready for review November 12, 2024 08:49
@LukaszRozmej
Copy link
Member

LukaszRozmej commented Nov 12, 2024

@anhnhgutech
Copy link
Contributor Author

Is this the same functionality as Geth?

Yes, that’s correct.

@LukaszRozmej LukaszRozmej merged commit 07f320e into NethermindEth:master Nov 12, 2024
77 checks passed
@anhnhgutech anhnhgutech deleted the fix/allow-overide-clique-vote branch November 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants