Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chainid to admin_nodeInfo rpc api #7743

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Add chainid to admin_nodeInfo rpc api #7743

merged 4 commits into from
Nov 12, 2024

Conversation

anhnhgutech
Copy link
Contributor

Add chainid to admin_nodeInfo rpc api

Changes

  • Add chainid to admin_nodeInfo RPC API
  • Fix network

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Screenshots

Screenshot 2024-11-09 at 22 09 01

@LukaszRozmej
Copy link
Member

Maybe a test could be added?

@LukaszRozmej LukaszRozmej marked this pull request as ready for review November 12, 2024 08:47
@LukaszRozmej LukaszRozmej merged commit 6edbb48 into NethermindEth:master Nov 12, 2024
77 checks passed
@anhnhgutech anhnhgutech deleted the fix/admin-node-info branch November 12, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anhnhgutech @LukaszRozmej