Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPC data handling #7714

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Fix IPC data handling #7714

merged 6 commits into from
Nov 6, 2024

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Nov 4, 2024

Changes

Fixed the issue when Nethermind doesn't work with Ethers or web3.js because of line feed handling.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Tested manually with Ethers, web3.js, and socat.

@rubo rubo requested a review from flcl42 November 4, 2024 20:52
@rubo rubo marked this pull request as ready for review November 6, 2024 21:10
@rubo rubo merged commit bba37d4 into master Nov 6, 2024
77 checks passed
@rubo rubo deleted the fix/ipc branch November 6, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants