-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for EIP7685, 7002 & 6110: Flat Encoding of requests #7670
Conversation
(cherry picked from commit bf78353)
(cherry picked from commit 6380314)
(cherry picked from commit cf58cd2)
(cherry picked from commit 7974a8b)
(cherry picked from commit 7b28007)
(cherry picked from commit 8f5c169)
(cherry picked from commit b1020eb)
(cherry picked from commit d30e193)
(cherry picked from commit 68c3736)
(cherry picked from commit d11df9c)
(cherry picked from commit b347664)
(cherry picked from commit caed2f3)
(cherry picked from commit bb7c803)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still few minor improvements can be done
src/Nethermind/Nethermind.Consensus.Test/ExecutionRequestProcessorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor stuff missing.
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequestExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #7525
Closes #7524
Closes #7522
Resolves #7521
Changes
Implements changes from
engine: unified list of opaque requests execution-apis#577Types of changes
engine_getPayloadV4
andengine_getPayloadV4
, It incorporates suggestions from pectra-devnet4 doc, which was to exchangerequests
as a side car and remove them from the block bodyengine_getPayloadBodiesByRangeV2
andengine_getPayloadBodiesByHashV2
and all related objects and handlers, which are now obsolete.IExecutionRequestsProcess
and gets rid of all kinds of exiting requests processors.RequestsHash
calculation, more info at: https://eips.ethereum.org/EIPS/eip-7685What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Few more tests are yet to be written after a few rounds of discussions.
Documentation
Requires documentation update
Remarks
Please verify the
requestsHash
calculation, which should be done as follow: