Show mev and extra data in block logs #7661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Nethermind/Nethermind.Consensus/Processing/BlockchainProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Handlers/ForkchoiceUpdatedHandler.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Oct 28, 2024
Comment on lines
+285
to
+290
| private static HashSet<AddressAsKey> _alternateMevPayees = new() | ||
| { | ||
| new Address("0xa83114A443dA1CecEFC50368531cACE9F37fCCcb"), // Extra data as: beaverbuild.org | ||
| new Address("0x9FC3da866e7DF3a1c57adE1a97c9f00a70f010c8"), // Extra data as: Titan (titanbuilder.xyz) | ||
| new Address("0x0b92619DdE55C0cbf828d32993a7fB004E00c84B"), // Extra data as: Builder+ www.btcs.com/builder | ||
| }; |
There was a problem hiding this comment.
Do we want it hardcoded here? Aren't there more?
There was a problem hiding this comment.
These aren't the actual main builders; just ones pretending to be them
95% of mev blocks are picked up by the main pattern where the GasBeneficiary pays the validator in the last tx; these ones pay from a different source.
Really should be in config rather than code, but I have only seen 3 so far
src/Nethermind/Nethermind.Merge.Plugin/Handlers/NewPayloadHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukasz Rozmej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing