Staging branch for devnet 4 #7607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 77f2423)
(cherry picked from commit bf81101)
(cherry picked from commit 7dbfcc3)
(cherry picked from commit 0cc3cfe)
(cherry picked from commit 021792d)
(cherry picked from commit c7e9f61)
(cherry picked from commit 29ea2ec)
(cherry picked from commit 6625445)
(cherry picked from commit 2f70584)
(cherry picked from commit 73b86bd)
(cherry picked from commit 3b8d8fa)
(cherry picked from commit 3dbb0ef)
(cherry picked from commit 419d727)
(cherry picked from commit 19f3ad5)
(cherry picked from commit 5c1e3dc)
(cherry picked from commit 0739aaa)
(cherry picked from commit bf78353)
(cherry picked from commit 6380314)
(cherry picked from commit cf58cd2)
(cherry picked from commit 7974a8b)
(cherry picked from commit 7b28007)
(cherry picked from commit 8f5c169)
MarekM25
reviewed
Oct 17, 2024
src/Nethermind/Ethereum.Blockchain.Pyspec.Test/LoadPyspecTestsStrategy.cs
Outdated
Show resolved
Hide resolved
ak88
commented
Oct 22, 2024
src/Nethermind/Nethermind.Blockchain.Test/Validators/TxValidatorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/ExecutionRequests/ExecutionRequestProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/Validators/BlockValidatorTests.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequest.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequest.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequest.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Core/ExecutionRequest/ExecutionRequest.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public static ArrayPoolList<byte[]> GetFlatEncodedRequests( |
There was a problem hiding this comment.
Is this structure really needed in the block itself?
There was a problem hiding this comment.
do you mean, is there need to specify ExecutionRequests field in the block ?
It is a workaround to to populate ExecutionRequests in GetPayloadResultV4, which is returned by engine_getPaylaodV4
There was a problem hiding this comment.
Yes, i can see that. I was thinking maybe we could isolate it to being in IBlockProductionContext in the cache or something like that.
There was a problem hiding this comment.
Yep, I was thinking to isolate it, but it would've required to create a wrapper to a block so that result of
contains the requests. Moreover, changes at many places would have to be done, all the way up to theblockProcessor step.
To avoid all of these complexities, I chose to create a new field under Block class
rjnrohit
force-pushed
the
pectra_devnet_4
branch
2 times, most recently
from
49fb5cc to
1a6b6d9
Compare
rjnrohit
changed the title
rjnrohit
changed the title
|
superceded by #7670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes for pecta devnet 4