Add pivot updator for optimism #7586
Conversation
|
Wouldn't it be safer to get Head - N blocks? (Whatever that N would be) |
|
@LukaszRozmej it would be safer, but then we need to refactor and complicate the logic way more Right now we are getting block hash and we are asking peers for a block by hash. Then we have block number and that's it. If we want to have |
|
Ok after discussion we need to use |
…ethermindEth/nethermind into feature/optimism_pivot_updator
# Conflicts: # src/Nethermind/Nethermind.Runner/configs/base-mainnet.cfg # src/Nethermind/Nethermind.Runner/configs/base-sepolia.cfg # src/Nethermind/Nethermind.Runner/configs/op-mainnet.cfg # src/Nethermind/Nethermind.Runner/configs/op-sepolia.cfg
| blockCacheService, beaconSyncStrategy, metadataDb, logManager) | ||
| { | ||
|
|
||
| private const int NumberOfBlocksBehindHeadForSettingPivot = 64; |
| Hash256? finalizedBlockHash = _beaconSyncStrategy.GetFinalizedHash(); | ||
|
|
||
| if (finalizedBlockHash is null || finalizedBlockHash == Keccak.Zero) | ||
| { | ||
| if (_logger.IsInfo && (_maxAttempts - _attemptsLeft) % 10 == 0) _logger.Info($"Waiting for Forkchoice message from Consensus Layer to set fresh pivot block [{_maxAttempts - _attemptsLeft}s]"); | ||
|
|
||
| PrintWaitingForMessageFromCl(); |
There was a problem hiding this comment.
when you invert this if then the override looks quite similar in structure and probably can be mostly shared.
| return null; | ||
| } | ||
|
|
||
| private long? TryGetHeadBlockNumberFromBlockCache(Hash256 headBlockHash) |
There was a problem hiding this comment.
more or less same as TryGetFinalizedBlockNumberFromBlockCache
| return null; | ||
| } | ||
|
|
||
| private async Task<long> TryGetHeadBlockNumberFromPeers(Hash256 headBlockHash, CancellationToken cancellationToken) |
There was a problem hiding this comment.
more or less the same as TryGetFinalizedBlockNumberFromPeers
| return null; | ||
| } | ||
|
|
||
| private async Task<Hash256?> TryGetPotentialPivotBlockHashFromPeers(long potentialPivotBlockNumber, CancellationToken cancellationToken) |
There was a problem hiding this comment.
very similar to other peer methods TryGetPotentialPivotBlockHashFromPeers
Changes
UnsafePivotUpdatorwhich is working similar as generalPivotUpdatorexcept using head block hash (minus 64 blocks) instead of finalized block hash.In
PivotUpdatorwe are using finalized block hash, because it can't be reorganized so is a safe starting point. Optimism is not providing finalized block hash until fully synced, so we need to use unsafe head block hash, which potentially can be reorganized and break the node. For more safety we are using head block minus 64. On Optimism reorganizations aren't common, so it can be a justified risk to significantly improve UX in most casesTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?